Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1078913002: Revert of bindings: Move named/indexed attributes to prototype chains. (Closed)

Created:
5 years, 8 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 8 months ago
Reviewers:
haraken, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink, vivekg
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Revert of bindings: Move named/indexed attributes to prototype chains. (patchset #3 id:40001 of https://codereview.chromium.org/1062713003/) Reason for revert: Speculatively rolling out. Appears to be causing massive Browser Test failures: http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/32444 crbug.com/475606 Original issue's description: > bindings: Move named/indexed attributes to prototype chains. > > BUG=43394, 470671 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193448 TBR=haraken@chromium.org,yukishiino@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=43394, 470671 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1279 lines, -1749 lines) Patch
M LayoutTests/fast/svg/svglist.html View 2 chunks +106 lines, -106 lines 0 comments Download
A LayoutTests/fast/svg/svglist-expected.txt View 1 chunk +33 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-command-copy-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M LayoutTests/inspector/console/console-format-collections-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 31 chunks +3 lines, -156 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-interface-listing-expected.txt View 35 chunks +3 lines, -177 lines 0 comments Download
M LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/scripts/v8_attributes.py View 1 chunk +7 lines, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 46 chunks +158 lines, -184 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 212 chunks +914 lines, -1056 lines 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterface5.cpp View 14 chunks +51 lines, -62 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
leviw_travelin_and_unemployed
Created Revert of bindings: Move named/indexed attributes to prototype chains.
5 years, 8 months ago (2015-04-09 20:34:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078913002/1
5 years, 8 months ago (2015-04-09 20:35:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=193476
5 years, 8 months ago (2015-04-09 20:36:20 UTC) #3
haraken
On 2015/04/09 20:36:20, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 8 months ago (2015-04-09 23:08:47 UTC) #4
Yuki
5 years, 8 months ago (2015-04-10 06:52:58 UTC) #5
Message was sent while issue was closed. 
Thanks!!  lgtm.

Powered by Google App Engine
This is Rietveld 408576698