Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 1078913002: Revert of bindings: Move named/indexed attributes to prototype chains. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_attributes.py
diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py
index d386f481ef5b6bbaedec81430a8f811ec6761934..c8b42f5bbfe407facefe6848dd6ade5467fab6db 100644
--- a/Source/bindings/scripts/v8_attributes.py
+++ b/Source/bindings/scripts/v8_attributes.py
@@ -528,7 +528,13 @@
if (is_constructor_attribute(attribute) or
has_custom_getter(attribute) or
has_custom_setter(attribute) or
- interface.name == 'Window'):
+ interface.name == 'Window' or
+ v8_utilities.indexed_property_getter(interface) or
+ v8_utilities.indexed_property_setter(interface) or
+ v8_utilities.indexed_property_deleter(interface) or
+ v8_utilities.named_property_getter(interface) or
+ v8_utilities.named_property_setter(interface) or
+ v8_utilities.named_property_deleter(interface)):
return False
return is_accessor
« no previous file with comments | « LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt ('k') | Source/bindings/tests/results/core/V8TestInterface.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698