Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1078543002: [Extensions] Make extension message bubble factory platform-abstract (Closed)

Created:
5 years, 8 months ago by Devlin
Modified:
5 years, 8 months ago
Reviewers:
Finnur, sky
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Make extension message bubble factory platform-abstract We want to show extension message bubbles on multiple platforms; the first step towards this is to make the bubble factory platform-abstract. Do so, and as an added bonus, shave off 200 lines of code. BUG=474092 Committed: https://crrev.com/a9a17da0de2260f6cb1a10b542a6d3a2b5fbf504 Cr-Commit-Position: refs/heads/master@{#324715}

Patch Set 1 : #

Total comments: 7

Patch Set 2 : Finnur's #

Patch Set 3 : ChromeOS fix #

Patch Set 4 : Re-Upload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+342 lines, -526 lines) Patch
M chrome/browser/extensions/dev_mode_bubble_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble.h View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller.cc View 2 chunks +9 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extension_message_bubble_controller_unittest.cc View 1 2 20 chunks +47 lines, -47 lines 0 comments Download
M chrome/browser/extensions/ntp_overridden_bubble_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/proxy_overridden_bubble_controller.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/settings_api_bubble_controller.cc View 3 chunks +24 lines, -3 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/OWNERS View 1 1 chunk +4 lines, -1 line 0 comments Download
A chrome/browser/ui/extensions/extension_message_bubble_factory.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/ui/extensions/extension_message_bubble_factory.cc View 1 chunk +92 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar.cc View 4 chunks +19 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_bar_delegate.h View 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.h View 4 chunks +0 lines, -125 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 7 chunks +3 lines, -275 lines 0 comments Download
M chrome/browser/ui/views/settings_api_bubble_helper_views.cc View 3 chunks +15 lines, -25 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 4 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.h View 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 3 chunks +1 line, -13 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
Devlin
Hey Finnur - I think this one's ready. My plan for this (the bug) is ...
5 years, 8 months ago (2015-04-10 00:29:00 UTC) #5
Devlin
https://codereview.chromium.org/1078543002/diff/60001/chrome/browser/ui/extensions/OWNERS File chrome/browser/ui/extensions/OWNERS (right): https://codereview.chromium.org/1078543002/diff/60001/chrome/browser/ui/extensions/OWNERS#newcode6 chrome/browser/ui/extensions/OWNERS:6: per-file extension*=rdevlin.cronin@chromium.org Also lemme know if you're okay with ...
5 years, 8 months ago (2015-04-10 00:30:13 UTC) #6
Finnur
LGTM https://codereview.chromium.org/1078543002/diff/60001/chrome/browser/extensions/proxy_overridden_bubble_controller.cc File chrome/browser/extensions/proxy_overridden_bubble_controller.cc (right): https://codereview.chromium.org/1078543002/diff/60001/chrome/browser/extensions/proxy_overridden_bubble_controller.cc#newcode166 chrome/browser/extensions/proxy_overridden_bubble_controller.cc:166: return true; The NTP override bubble delegate returns ...
5 years, 8 months ago (2015-04-10 11:24:21 UTC) #7
Devlin
https://codereview.chromium.org/1078543002/diff/60001/chrome/browser/extensions/proxy_overridden_bubble_controller.cc File chrome/browser/extensions/proxy_overridden_bubble_controller.cc (right): https://codereview.chromium.org/1078543002/diff/60001/chrome/browser/extensions/proxy_overridden_bubble_controller.cc#newcode166 chrome/browser/extensions/proxy_overridden_bubble_controller.cc:166: return true; On 2015/04/10 11:24:21, Finnur wrote: > The ...
5 years, 8 months ago (2015-04-10 15:55:20 UTC) #8
Devlin
Scott, mind taking a quick look at toolbar_view.*, and confirming the OWNERS change is okay?
5 years, 8 months ago (2015-04-10 16:25:36 UTC) #10
sky
I can't seem to view side-by-side diffs. Could you try reuploading?
5 years, 8 months ago (2015-04-10 19:24:39 UTC) #11
Devlin
On 2015/04/10 19:24:39, sky wrote: > I can't seem to view side-by-side diffs. Could you ...
5 years, 8 months ago (2015-04-10 19:31:16 UTC) #12
sky
LGTM
5 years, 8 months ago (2015-04-10 20:01:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1078543002/120001
5 years, 8 months ago (2015-04-10 21:19:27 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:120001)
5 years, 8 months ago (2015-04-10 23:58:00 UTC) #17
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/a9a17da0de2260f6cb1a10b542a6d3a2b5fbf504 Cr-Commit-Position: refs/heads/master@{#324715}
5 years, 8 months ago (2015-04-10 23:59:12 UTC) #18
Devlin
5 years, 8 months ago (2015-04-13 17:40:44 UTC) #19
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:120001) has been created in
https://codereview.chromium.org/1081113002/ by rdevlin.cronin@chromium.org.

The reason for reverting is: Looks like this caused crbug.com/476426. Reverting
to investigate..

Powered by Google App Engine
This is Rietveld 408576698