chrome/browser/ui/extensions/OWNERS - Issue 1078543002: [Extensions] Make extension message bubble factory platform-abstract

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/extensions/OWNERS

Issue 1078543002: [Extensions] Make extension message bubble factory platform-abstract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/extensions/proxy_overridden_bubble_controller.cc ('K') | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/extensions/extension_message_bubble_factory.h » ('j') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 benwells@chromium.org	1 benwells@chromium.org

2 miket@chromium.org	2 miket@chromium.org

3	3

4 # Extension/Toolbar Actions Files	4 # Extension/Toolbar Actions Files

5 per-file extension_action*=finnur@chromium.org	5 per-file extension*=finnur@chromium.org

6 per-file extension_action*=rdevlin.cronin@chromium.org	6 per-file extension*=rdevlin.cronin@chromium.org
	Devlin 2015/04/10 00:30:13 Also lemme know if you're okay with this - after a Also lemme know if you're okay with this - after a bit of thought, it seems more appropriate (to grasp this, the install ui, etc). I'll run it by Scott if you think it's okay. Finnur 2015/04/10 11:24:21 The name for this directory is so general that I w The name for this directory is so general that I worry all kinds of crap is going to be added to it that we probably shouldn't be owners of (even with the limitation of the extension_ prefix, which is pretty general). Is there a pattern to this that make sense to exploit (e.g. the ones related to install, put them in a subdirectory 'install' so we don't have to take ownership of future random stuff)? :) Devlin 2015/04/10 15:55:19 I think we try to avoid having really fine-grained Show quoted text On 2015/04/10 11:24:21, Finnur wrote: > The name for this directory is so general that I worry all kinds of crap is > going to be added to it that we probably shouldn't be owners of (even with the > limitation of the extension_ prefix, which is pretty general). Is there a > pattern to this that make sense to exploit (e.g. the ones related to install, > put them in a subdirectory 'install' so we don't have to take ownership of > future random stuff)? :) I think we try to avoid having really fine-grained directories (for better or worse - I'd probably prefer it, but I see the advantage both ways, and best to stick to the norm), so I think having a directory for "install" and a directory for "bubble" and a directory for "extension_action" is probably wrong. But you're also definitely right that we don't want to accidentally end up owning "random" stuff. :) So, in lieu of that, I'd be inclined to say that a few extra lines in OWNERS files is okay, and just add in explicit rules - it's still readable, and more accurate overall. :)
OLD	NEW