chrome/browser/extensions/proxy_overridden_bubble_controller.cc - Issue 1078543002: [Extensions] Make extension message bubble factory platform-abstract

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/proxy_overridden_bubble_controller.cc

Issue 1078543002: [Extensions] Make extension message bubble factory platform-abstract (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Re-Upload Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/ntp_overridden_bubble_controller.cc ('k') | chrome/browser/extensions/settings_api_bubble_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/proxy_overridden_bubble_controller.cc

diff --git a/chrome/browser/extensions/proxy_overridden_bubble_controller.cc b/chrome/browser/extensions/proxy_overridden_bubble_controller.cc

index a3cde4cacb2f36c9ebb0fe95f232d9cd66182080..d25204d58bdf097f6c06fcd19cd6a3ac57e658dd 100644

--- a/chrome/browser/extensions/proxy_overridden_bubble_controller.cc

+++ b/chrome/browser/extensions/proxy_overridden_bubble_controller.cc

@@ -51,6 +51,7 @@ class ProxyOverriddenBubbleDelegate

base::string16 GetActionButtonLabel() const override;

base::string16 GetDismissButtonLabel() const override;

bool ShouldShowExtensionList() const override;

+ bool ShouldHighlightExtensions() const override;

void RestrictToSingleExtension(const std::string& extension_id) override;

void LogExtensionCount(size_t count) override;

void LogAction(

@@ -161,6 +162,10 @@ bool ProxyOverriddenBubbleDelegate::ShouldShowExtensionList() const {

return false;

}

+bool ProxyOverriddenBubbleDelegate::ShouldHighlightExtensions() const {

+ return true;

void ProxyOverriddenBubbleDelegate::RestrictToSingleExtension(

const std::string& extension_id) {

extension_id_ = extension_id;