DescriptionRevert of Refactor GestureNavigation to eliminate code redundancy (patchset #32 id:620001 of https://codereview.chromium.org/895543005/)
Reason for revert:
After this CL, content browsertest WebContentsViewAuraTest.RepeatedQuickOverscrollGestures started failing with segmentation fault on almost every run on Linux ChromiumOS Tests (dbg)(1).
See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/850
Original issue's description:
> Refactor GestureNavigation to eliminate code redundancy
>
> Right now, Gesture Navigation has two very distinct phases: the initial
> one, where the web contents window receives events and is moved, and the
> follow up navigation, where the page still hasn't loaded and the user
> scrolls on the overlay. The meat of this patch is to unify as much of
> the logic as possible without sacrificing features. A new class is
> introduced, OverscrollWindowAnimation, and the responsibility of the
> existing OverscrollNavigationOverlay is steered into performing the
> actual navigation.
>
> TEST=Overscroll*
> BUG=467692, 464532, 420121
>
> Committed: https://crrev.com/5384f002f839439ef666ed9688069e42ca5ccdca
> Cr-Commit-Position: refs/heads/master@{#324275}
TBR=mfomitchev@chromium.org,sadrul@chromium.org,danakj@chromium.org,avi@chromium.org,nsatragno@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=467692, 464532, 420121
Committed: https://crrev.com/b09645cceb8c39dba79333eb1e703377aa20c7b6
Cr-Commit-Position: refs/heads/master@{#324415}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|