Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1076743003: Revert of Refactor GestureNavigation to eliminate code redundancy (Closed)

Created:
5 years, 8 months ago by engedy
Modified:
5 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, tdanderson
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor GestureNavigation to eliminate code redundancy (patchset #32 id:620001 of https://codereview.chromium.org/895543005/) Reason for revert: After this CL, content browsertest WebContentsViewAuraTest.RepeatedQuickOverscrollGestures started failing with segmentation fault on almost every run on Linux ChromiumOS Tests (dbg)(1). See: http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/850 Original issue's description: > Refactor GestureNavigation to eliminate code redundancy > > Right now, Gesture Navigation has two very distinct phases: the initial > one, where the web contents window receives events and is moved, and the > follow up navigation, where the page still hasn't loaded and the user > scrolls on the overlay. The meat of this patch is to unify as much of > the logic as possible without sacrificing features. A new class is > introduced, OverscrollWindowAnimation, and the responsibility of the > existing OverscrollNavigationOverlay is steered into performing the > actual navigation. > > TEST=Overscroll* > BUG=467692, 464532, 420121 > > Committed: https://crrev.com/5384f002f839439ef666ed9688069e42ca5ccdca > Cr-Commit-Position: refs/heads/master@{#324275} TBR=mfomitchev@chromium.org,sadrul@chromium.org,danakj@chromium.org,avi@chromium.org,nsatragno@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467692, 464532, 420121 Committed: https://crrev.com/b09645cceb8c39dba79333eb1e703377aa20c7b6 Cr-Commit-Position: refs/heads/master@{#324415}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1788 lines, -1430 lines) Patch
M content/browser/BUILD.gn View 1 chunk +2 lines, -4 lines 0 comments Download
M content/browser/renderer_host/overscroll_controller_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.h View 3 chunks +67 lines, -62 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay.cc View 6 chunks +166 lines, -128 lines 0 comments Download
M content/browser/web_contents/aura/overscroll_navigation_overlay_unittest.cc View 6 chunks +81 lines, -261 lines 0 comments Download
D content/browser/web_contents/aura/overscroll_window_animation.h View 1 chunk +0 lines, -121 lines 0 comments Download
D content/browser/web_contents/aura/overscroll_window_animation.cc View 1 chunk +0 lines, -151 lines 0 comments Download
D content/browser/web_contents/aura/overscroll_window_animation_unittest.cc View 1 chunk +0 lines, -226 lines 0 comments Download
D content/browser/web_contents/aura/overscroll_window_delegate.h View 1 chunk +0 lines, -73 lines 0 comments Download
D content/browser/web_contents/aura/overscroll_window_delegate.cc View 1 chunk +0 lines, -129 lines 0 comments Download
D content/browser/web_contents/aura/overscroll_window_delegate_unittest.cc View 1 chunk +0 lines, -242 lines 0 comments Download
A content/browser/web_contents/aura/window_slider.h View 1 chunk +156 lines, -0 lines 0 comments Download
A content/browser/web_contents/aura/window_slider.cc View 1 chunk +309 lines, -0 lines 0 comments Download
A content/browser/web_contents/aura/window_slider_unittest.cc View 1 chunk +639 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 7 chunks +39 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 14 chunks +324 lines, -23 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
engedy
Created Revert of Refactor GestureNavigation to eliminate code redundancy
5 years, 8 months ago (2015-04-09 11:32:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1076743003/1
5 years, 8 months ago (2015-04-09 11:33:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 11:33:47 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b09645cceb8c39dba79333eb1e703377aa20c7b6 Cr-Commit-Position: refs/heads/master@{#324415}
5 years, 8 months ago (2015-04-09 11:34:34 UTC) #4
engedy
5 years, 8 months ago (2015-04-09 11:40:36 UTC) #5
Message was sent while issue was closed.
Top of stack trace from local repro:

#0  content::InterstitialPageImpl::GetView (this=0xcdcdcdcdcdcdcdcd)
    at ../../content/browser/frame_host/interstitial_page_impl.cc:692
#1  0x00007fffea27c5f2 in
content::RenderFrameHostManager::GetRenderWidgetHostView (
    this=0x3a783f34ab30) at
../../content/browser/frame_host/render_frame_host_manager.cc:142
#2  0x00007fffea9888dd in content::WebContentsImpl::GetRenderWidgetHostView
(this=0x3a783f4f9820)
    at ../../content/browser/web_contents/web_contents_impl.cc:685
#3  0x00007fffea9c2690 in content::WebContentsViewAura::GetContentNativeView
(this=0x3a783f4be660)
    at ../../content/browser/web_contents/web_contents_view_aura.cc:771
#4  0x00007fffea99073d in content::WebContentsImpl::GetContentNativeView
(this=0x3a783f4f9820)
    at ../../content/browser/web_contents/web_contents_impl.cc:2157
#5  0x00007fffea97be9a in content::OverscrollNavigationOverlay::GetMainWindow
(this=0x3a783f58c620)
    at
../../content/browser/web_contents/aura/overscroll_navigation_overlay.cc:216
#6  0x00007fffea97b504 in
content::OverscrollNavigationOverlay::~OverscrollNavigationOverlay (
    this=0x3a783f58c620)
    at
../../content/browser/web_contents/aura/overscroll_navigation_overlay.cc:119
#7  0x00007fffea97b5e9 in
content::OverscrollNavigationOverlay::~OverscrollNavigationOverlay (
    this=0x3a783f58c620)
    at
../../content/browser/web_contents/aura/overscroll_navigation_overlay.cc:117
#8  0x00007fffea9c71ef in
base::DefaultDeleter<content::OverscrollNavigationOverlay>::operator() (
    this=0x3a783f4be748, ptr=0x3a783f58c620) at
../../base/memory/scoped_ptr.h:128
#9  0x00007fffea9c9735 in
base::internal::scoped_ptr_impl<content::OverscrollNavigationOverlay,
base::DefaultDeleter<content::OverscrollNavigationOverlay> >::reset
(this=0x3a783f4be748, p=0x0)
    at ../../base/memory/scoped_ptr.h:248
#10 0x00007fffea9c695d in scoped_ptr<content::OverscrollNavigationOverlay,
base::DefaultDeleter<content::OverscrollNavigationOverlay> >::reset
(this=0x3a783f4be748, p=0x0)
    at ../../base/memory/scoped_ptr.h:377
#11 0x00007fffea9c498a in content::WebContentsViewAura::OnWindowDestroying
(this=0x3a783f4be660, 
    window=0x3a783f34ade0) at
../../content/browser/web_contents/web_contents_view_aura.cc:1193
#12 0x00007fffea9c49bc in non-virtual thunk to
content::WebContentsViewAura::OnWindowDestroying(aura::Window*) () at
../../content/browser/web_contents/web_contents_view_aura.cc:1187
#13 0x00007ffff4160375 in aura::Window::~Window (this=0x3a783f34ade0) at
../../ui/aura/window.cc:211
#14 0x00007ffff4160d89 in aura::Window::~Window (this=0x3a783f34ade0) at
../../ui/aura/window.cc:204
#15 0x00007fffea97cf8f in base::DefaultDeleter<aura::Window>::operator()
(this=0x3a783f4be700, 
    ptr=0x3a783f34ade0) at ../../base/memory/scoped_ptr.h:128
#16 0x00007fffea97d355 in base::internal::scoped_ptr_impl<aura::Window,
base::DefaultDeleter<aura::Window> >::reset (this=0x3a783f4be700, p=0x0) at
../../base/memory/scoped_ptr.h:248
#17 0x00007fffea97c8bd in scoped_ptr<aura::Window,
base::DefaultDeleter<aura::Window> >::reset (
    this=0x3a783f4be700, p=0x0) at ../../base/memory/scoped_ptr.h:377
#18 0x00007fffea9c1bcb in content::WebContentsViewAura::~WebContentsViewAura
(this=0x3a783f4be660)
    at ../../content/browser/web_contents/web_contents_view_aura.cc:685
#19 0x00007fffea9c1d99 in content::WebContentsViewAura::~WebContentsViewAura
(this=0x3a783f4be660)
    at ../../content/browser/web_contents/web_contents_view_aura.cc:676
#20 0x00007fffea9a1f2f in
base::DefaultDeleter<content::WebContentsView>::operator() (
    this=0x3a783f4f9a18, ptr=0x3a783f4be660) at
../../base/memory/scoped_ptr.h:128
#21 0x00007fffea9a1ef1 in
base::internal::scoped_ptr_impl<content::WebContentsView,
base::DefaultDeleter<content::WebContentsView> >::~scoped_ptr_impl
(this=0x3a783f4f9a18)
    at ../../base/memory/scoped_ptr.h:222
#22 0x00007fffea99afe5 in scoped_ptr<content::WebContentsView,
base::DefaultDeleter<content::WebContentsView> >::~scoped_ptr
(this=0x3a783f4f9a18) at ../../base/memory/scoped_ptr.h:312
#23 0x00007fffea983407 in content::WebContentsImpl::~WebContentsImpl
(this=0x3a783f4f9820)
    at ../../content/browser/web_contents/web_contents_impl.cc:424
#24 0x00007fffea983779 in content::WebContentsImpl::~WebContentsImpl
(this=0x3a783f4f9820)
    at ../../content/browser/web_contents/web_contents_impl.cc:357
#25 0x00000000004c78bf in
base::DefaultDeleter<content::AccessibilityEventRecorder>::operator() (
    this=0x3a783f529540, ptr=0x3a783f4f9820) at
../../base/memory/scoped_ptr.h:128
#26 0x00000000004c7881 in
base::internal::scoped_ptr_impl<content::AccessibilityEventRecorder,
base::DefaultDeleter<content::AccessibilityEventRecorder> >::~scoped_ptr_impl
(this=0x3a783f529540)
    at ../../base/memory/scoped_ptr.h:222
#27 0x00000000006335a5 in scoped_ptr<content::WebContents,
base::DefaultDeleter<content::WebContents> >::~scoped_ptr (this=0x3a783f529540)
at ../../base/memory/scoped_ptr.h:312
#28 0x0000000000700669 in content::Shell::~Shell (this=0x3a783f5294d0)
    at ../../content/shell/browser/shell.cc:95
#29 0x0000000000700709 in content::Shell::~Shell (this=0x3a783f5294d0)
    at ../../content/shell/browser/shell.cc:79
#30 0x00000000007123ab in content::(anonymous
namespace)::ShellWindowDelegateView::WindowClosing (
    this=0x3a783f51d220) at ../../content/shell/browser/shell_views.cc:344
#31 0x00007ffff32499e6 in views::Widget::OnNativeWidgetDestroying
(this=0x3a783f72a460)
    at ../../ui/views/widget/widget.cc:1111
#32 0x00007ffff328578c in views::NativeWidgetAura::OnWindowDestroying
(this=0x3a783f345c80, 
    window=0x3a783f34b0a0) at ../../ui/views/widget/native_widget_aura.cc:839
#33 0x00007ffff32857dc in non-virtual thunk to
views::NativeWidgetAura::OnWindowDestroying(aura::Window*) () at
../../ui/views/widget/native_widget_aura.cc:837
#34 0x00007ffff4160375 in aura::Window::~Window (this=0x3a783f34b0a0) at
../../ui/aura/window.cc:211
#35 0x00007ffff4160d89 in aura::Window::~Window (this=0x3a783f34b0a0) at
../../ui/aura/window.cc:204
#36 0x00007ffff3283b42 in views::NativeWidgetAura::CloseNow
(this=0x3a783f345c80)
    at ../../ui/views/widget/native_widget_aura.cc:465
#37 0x00007ffff3247c33 in views::Widget::CloseNow (this=0x3a783f72a460)
    at ../../ui/views/widget/widget.cc:599
#38 0x0000000000711e94 in content::Shell::Close (this=0x3a783f5294d0)
    at ../../content/shell/browser/shell_views.cc:540
#39 0x00000000007008dd in content::Shell::CloseAllWindows ()
    at ../../content/shell/browser/shell.cc:123
#40 0x00000000006ecca8 in content::ContentBrowserTest::RunTestOnMainThreadLoop
(this=0x3a783f300800)
    at ../../content/public/test/content_browser_test.cc:157
#41 0x00000000007d4865 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop
(
    this=0x3a783f300800) at ../../content/public/test/browser_test_base.cc:295
#42 0x00000000004e7479 in base::internal::RunnableAdapter<void
(content::CrossSiteTransferTest::*)()>::Run (this=0x7fffffffba70,
object=0x3a783f300800) at ../../base/bind_internal.h:176
#43 0x00000000005fc669 in base::internal::InvokeHelper<false, void,
base::internal::RunnableAdapter<void (content::ServiceWorkerBrowserTest::*)()>,
base::internal::TypeList<content::ServiceWorkerBrowserTest* const&> >::MakeItSo
(runnable=..., args=@0x3a783f24d9e8: 0x3a783f300800)
    at ../../base/bind_internal.h:293
#44 0x00000000007d5960 in base::internal::Invoker<IndexSequence<0ul>,
base::internal::BindState<base::internal::RunnableAdapter<void
(content::BrowserTestBase::*)()>, void (content::BrowserTestBase*),
base::internal::TypeList<content::BrowserTestBase*> >,
base::internal::TypeList<base::internal::UnwrapTraits<content::BrowserTestBase*>
>, base::internal::InvokeHelper<false, void,
base::internal::RunnableAdapter<void (content::BrowserTestBase::*)()>,
base::internal::TypeList<content::BrowserTestBase* const&> >, void
()>::Run(base::internal::BindStateBase*) (base=0x3a783f24d9c0)
    at ../../base/bind_internal.h:343
#45 0x00000000004d106e in base::Callback<void ()>::Run() const
(this=0x3a783f298930)
    at ../../base/callback.h:396
#46 0x000000000074c955 in content::ShellBrowserMainParts::PreMainMessageLoopRun
(this=0x3a783f2fa2a0)
    at ../../content/shell/browser/shell_browser_main_parts.cc:152
#47 0x00007fffe9fef655 in content::BrowserMainLoop::PreMainMessageLoopRun
(this=0x3a783f32d020)
    at ../../content/browser/browser_main_loop.cc:786
#48 0x00007fffe9ff6e69 in base::internal::RunnableAdapter<int
(content::BrowserMainLoop::*)()>::Run (
    this=0x7fffffffbc00, object=0x3a783f32d020) at
../../base/bind_internal.h:176
#49 0x00007fffe9ff6dec in base::internal::InvokeHelper<false, int,
base::internal::RunnableAdapter<int (content::BrowserMainLoop::*)()>,
base::internal::TypeList<content::BrowserMainLoop*> >::MakeItSo (
    runnable=..., args=0x3a783f32d020) at ../../base/bind_internal.h:286
#50 0x00007fffe9ff6db8 in base::internal::Invoker<IndexSequence<0ul>,
base::internal::BindState<base::internal::RunnableAdapter<int
(content::BrowserMainLoop::*)()>, int (content::BrowserMainLoop*),
base::internal::TypeList<base::internal::UnretainedWrapper<content::BrowserMainLoop>
> >,
base::internal::TypeList<base::internal::UnwrapTraits<base::internal::UnretainedWrapper<content::BrowserMainLoop>
> >, base::internal::InvokeHelper<false, int,
base::internal::RunnableAdapter<int (content::BrowserMainLoop::*)()>,
base::internal::TypeList<content::BrowserMainLoop*> >, int
()>::Run(base::internal::BindStateBase*) (base=0x3a783f273800) at
../../base/bind_internal.h:343
#51 0x00007fffea557c0e in base::Callback<int ()>::Run() const
(this=0x3a783f3bfb10)
    at ../../base/callback.h:396
#52 0x00007fffea92fdeb in content::StartupTaskRunner::RunAllTasksNow
(this=0x3a783f2f47a0)
    at ../../content/browser/startup_task_runner.cc:45

Powered by Google App Engine
This is Rietveld 408576698