Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1074913004: Simplify protocol name and port comparison in KnwonPorts.cpp (Closed)

Created:
5 years, 8 months ago by kinuko
Modified:
5 years, 8 months ago
Reviewers:
Ian Wen, Mike West
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify protocol name and port comparison in KnwonPorts.cpp Locking on hashmap initialization may causes problem when constructing referer. Change it to a simpler approach. (Original patch https://codereview.chromium.org/895793003/ created by Ian Wen (Ianwen@) and added test) BUG=373141, 441605 TEST=KnownPortsTest.IsDefaultPortForProtocol Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194007

Patch Set 1 #

Patch Set 2 : added upper-case test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -8 lines) Patch
M Source/platform/blink_platform.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/weborigin/KnownPorts.cpp View 1 chunk +10 lines, -8 lines 0 comments Download
A Source/platform/weborigin/KnownPortsTest.cpp View 1 1 chunk +47 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Mike West
LGTM. Only thing I note here is that the function used to be case-insensitive. It's ...
5 years, 8 months ago (2015-04-20 07:06:34 UTC) #2
kinuko
On 2015/04/20 07:06:34, Mike West wrote: > LGTM. > > Only thing I note here ...
5 years, 8 months ago (2015-04-20 07:32:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1074913004/20001
5 years, 8 months ago (2015-04-20 07:33:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-20 09:18:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194007

Powered by Google App Engine
This is Rietveld 408576698