Simplify protocal name and port comparison

Simplify protocal name and port comparison

Locking on hashmap initialization may causes problem when constructing
referer. Change it to a simpler approach.

BUG=373141

[Ian Wen, 2015-02-03 00:49:40]

ianwen@chromium.org changed reviewers:
+ kinuko@chromium.org, mkwst@chromium.org

[kinuko, 2015-02-03 03:52:32]

This one lgtm, but if it's crashing on initialization I believe we can just
revert http://src.chromium.org/viewvc/blink?view=revision&revision=188885.

I made sure it doesn't crash with a thread assertion I'm planning to add
(https://codereview.chromium.org/874203002/), so it looks my fix was
false-alarming.

https://codereview.chromium.org/895793003/diff/20001/Source/platform/weborigi...
File Source/platform/weborigin/KnownPorts.cpp (right):

https://codereview.chromium.org/895793003/diff/20001/Source/platform/weborigi...
Source/platform/weborigin/KnownPorts.cpp:50: return port == 990;
Switching on port number, and then comparing protocol might be slightly faster?

[Ian Wen, 2015-02-03 19:08:54]

mkwst@, could you ptal? :-)

https://codereview.chromium.org/895793003/diff/20001/Source/platform/weborigi...
File Source/platform/weborigin/KnownPorts.cpp (right):

https://codereview.chromium.org/895793003/diff/20001/Source/platform/weborigi...
Source/platform/weborigin/KnownPorts.cpp:50: return port == 990;
On 2015/02/03 03:52:32, kinuko wrote:
> Switching on port number, and then comparing protocol might be slightly
faster?

Indeed. Done.

[Mike West, 2015-02-03 19:23:10]

LGTM.

If you're already poking at this, please consider adding a unit test to verify
the behavior (similar to the other *Test.cpp files in this directory).

[Ian Wen, 2015-02-03 21:08:41]

The CQ bit was checked by ianwen@chromium.org

[commit-bot: I haz the power, 2015-02-03 21:09:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895793003/40001

[commit-bot: I haz the power, 2015-02-03 23:43:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 23:43:15]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41100)

[Ian Wen, 2015-02-03 23:54:07]

New patchsets have been uploaded after l-g-t-m from mkwst@chromium.org

[kinuko, 2015-02-04 08:49:55]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2015-02-04 08:50:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/895793003/60001

[Mike West, 2015-02-04 09:01:59]

Can you add a test in a follow-up patch, please?

[kinuko, 2015-02-04 09:59:18]

+1

On 2015年2月4日(水) 18:02 null <mkwst@chromium.org> wrote:

> Can you add a test in a follow-up patch, please?
>
> https://codereview.chromium.org/895793003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-02-04 11:01:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-04 11:01:52]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/41302)

[Ian Wen, 2015-02-04 17:51:16]

Sure I will write a test for it later. The current patch is failing on Mac_rel
bot, which I haven't figured out why. :(

[Mike West, 2015-02-05 11:55:52]

I suspect the mac bot is just sick. :(

[kinuko, 2015-04-20 06:25:29]

Hey- I think I want to land this (I need this for my other change). I'm taking
over this with a test here: https://codereview.chromium.org/1074913004/

Hope it was fine with you!