Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1629)

Unified Diff: Source/platform/weborigin/KnownPorts.cpp

Issue 1074913004: Simplify protocol name and port comparison in KnwonPorts.cpp (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: added upper-case test case Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/weborigin/KnownPortsTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/weborigin/KnownPorts.cpp
diff --git a/Source/platform/weborigin/KnownPorts.cpp b/Source/platform/weborigin/KnownPorts.cpp
index d3fc9209ed953a7b8fad724f7ba02937ecf74fe6..d9b9f2a7d0c30bf5bd0b681d6a4f229c7ce45411 100644
--- a/Source/platform/weborigin/KnownPorts.cpp
+++ b/Source/platform/weborigin/KnownPorts.cpp
@@ -40,15 +40,17 @@ bool isDefaultPortForProtocol(unsigned short port, const String& protocol)
if (protocol.isEmpty())
return false;
- typedef HashMap<String, unsigned, CaseFoldingHash> DefaultPortsMap;
- AtomicallyInitializedStaticReference(DefaultPortsMap, defaultPorts, new DefaultPortsMap());
- if (defaultPorts.isEmpty()) {
- defaultPorts.set("http", 80);
- defaultPorts.set("https", 443);
- defaultPorts.set("ftp", 21);
- defaultPorts.set("ftps", 990);
+ switch (port) {
+ case 80:
+ return protocol == "http";
+ case 443:
+ return protocol == "https";
+ case 21:
+ return protocol == "ftp";
+ case 990:
+ return protocol == "ftps";
}
- return defaultPorts.get(protocol) == port;
+ return false;
}
}
« no previous file with comments | « Source/platform/blink_platform.gypi ('k') | Source/platform/weborigin/KnownPortsTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698