Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1073463003: MIPS: [turbofan] Add new Float32Abs and Float64Abs operators. (Closed)

Created:
5 years, 8 months ago by balazs.kilvady
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Add new Float32Abs and Float64Abs operators. Port 9af9f1d0262e2dab66c62331a03f6a76504f3866 Original commit message: These operators compute the absolute floating point value of some arbitrary input, and are implemented without any branches (i.e. using vabs on arm, and andps/andpd on x86). BUG= Committed: https://crrev.com/8c3af6ca03ffa8f61608614dc1c316d885a09801 Cr-Commit-Position: refs/heads/master@{#27679}

Patch Set 1 #

Patch Set 2 : Add missing unittest. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -8 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-codes-mips.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +12 lines, -5 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-codes-mips64.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +9 lines, -3 lines 0 comments Download
M src/mips/assembler-mips.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/assembler-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips64/assembler-mips64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips/instruction-selector-mips-unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M test/unittests/compiler/mips64/instruction-selector-mips64-unittest.cc View 1 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
balazs.kilvady
5 years, 8 months ago (2015-04-08 16:55:58 UTC) #2
paul.l...
LGTM. But missing mips64 unittests? You could add that here, or in a different CL ...
5 years, 8 months ago (2015-04-08 18:38:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073463003/20001
5 years, 8 months ago (2015-04-08 18:58:53 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 19:30:11 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 19:30:25 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8c3af6ca03ffa8f61608614dc1c316d885a09801
Cr-Commit-Position: refs/heads/master@{#27679}

Powered by Google App Engine
This is Rietveld 408576698