Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 1073323002: Use null rather than empty frame to lock Surface resources (Closed)

Created:
5 years, 8 months ago by brianderson
Modified:
5 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use null rather than empty frame to lock Surface resources This will allow the DisplayScheduler to differentiate between a frame without any resources and one that should not be drawn. Some tests use frames without any resources and the DisplayScheduler was missinterpreting that as the Browser locking resources. BUG=467750 Committed: https://crrev.com/5e5956af406aec997246697735a11f4222d83bef Cr-Commit-Position: refs/heads/master@{#324765}

Patch Set 1 #

Total comments: 1

Patch Set 2 : current_frame -> frame #

Patch Set 3 : Fix frame_index_ incrementing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M cc/surfaces/surface.cc View 1 2 2 chunks +18 lines, -7 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 2 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
brianderson
Is this sane? This helps fix the failures I was seeing with https://codereview.chromium.org/1012853003 on the ...
5 years, 8 months ago (2015-04-10 21:30:47 UTC) #2
jbauman
lgtm, with one change, as long as this doesn't hit DCHECKs anywhere. https://codereview.chromium.org/1073323002/diff/1/cc/surfaces/surface.cc File cc/surfaces/surface.cc ...
5 years, 8 months ago (2015-04-10 21:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1073323002/20001
5 years, 8 months ago (2015-04-11 00:24:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-11 03:19:34 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5e5956af406aec997246697735a11f4222d83bef Cr-Commit-Position: refs/heads/master@{#324765}
5 years, 8 months ago (2015-04-11 03:20:32 UTC) #8
brianderson
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1088883004/ by brianderson@chromium.org. ...
5 years, 8 months ago (2015-04-14 19:14:28 UTC) #9
brianderson
ptal
5 years, 8 months ago (2015-04-15 23:23:35 UTC) #10
jbauman
lgtm
5 years, 8 months ago (2015-04-15 23:24:35 UTC) #11
brianderson
5 years, 8 months ago (2015-04-15 23:29:22 UTC) #12
Message was sent while issue was closed.
Couldn't commit for some reason. Moving to:
https://codereview.chromium.org/1084313002

Powered by Google App Engine
This is Rietveld 408576698