Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 1088883004: Revert of Use null rather than empty frame to lock Surface resources (Closed)

Created:
5 years, 8 months ago by brianderson
Modified:
5 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use null rather than empty frame to lock Surface resources (patchset #2 id:20001 of https://codereview.chromium.org/1073323002/) Reason for revert: This is causing timeouts on the gpu bots: https://code.google.com/p/chromium/issues/detail?id=476544#c5 Original issue's description: > Use null rather than empty frame to lock Surface resources > > This will allow the DisplayScheduler to differentiate between > a frame without any resources and one that should not be drawn. > > Some tests use frames without any resources and the DisplayScheduler > was missinterpreting that as the Browser locking resources. > > BUG=467750 > > Committed: https://crrev.com/5e5956af406aec997246697735a11f4222d83bef > Cr-Commit-Position: refs/heads/master@{#324765} TBR=jbauman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467750 Committed: https://crrev.com/21df99ae0d91bcf2bc2deebef9cc0e850b27544e Cr-Commit-Position: refs/heads/master@{#325100}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -19 lines) Patch
M cc/surfaces/surface.cc View 2 chunks +6 lines, -17 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
brianderson
Created Revert of Use null rather than empty frame to lock Surface resources
5 years, 8 months ago (2015-04-14 19:14:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1088883004/1
5 years, 8 months ago (2015-04-14 19:15:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 19:16:06 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 19:17:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21df99ae0d91bcf2bc2deebef9cc0e850b27544e
Cr-Commit-Position: refs/heads/master@{#325100}

Powered by Google App Engine
This is Rietveld 408576698