Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1084313002: Use null rather than empty frame to lock Surface resources (Closed)

Created:
5 years, 8 months ago by brianderson
Modified:
5 years, 8 months ago
Reviewers:
jbauman
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use null rather than empty frame to lock Surface resources This will allow the DisplayScheduler to differentiate between a frame without any resources and one that should not be drawn. Some tests use frames without any resources and the DisplayScheduler was missinterpreting that as the Browser locking resources. BUG=467750, 476544 Committed: https://crrev.com/9576564d395425ce1c073fa3f33b8d5c062add8e Cr-Commit-Position: refs/heads/master@{#325369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M cc/surfaces/surface.cc View 2 chunks +18 lines, -7 lines 0 comments Download
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
brianderson
ptal
5 years, 8 months ago (2015-04-15 23:29:32 UTC) #2
jbauman
lgtm
5 years, 8 months ago (2015-04-15 23:32:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084313002/1
5 years, 8 months ago (2015-04-15 23:35:06 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-16 01:33:01 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 01:33:53 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9576564d395425ce1c073fa3f33b8d5c062add8e
Cr-Commit-Position: refs/heads/master@{#325369}

Powered by Google App Engine
This is Rietveld 408576698