Clean up Blink left-overs of textual persistent notification ids.

Clean up Blink left-overs of textual persistent notification ids.

This CL is part of a three-sided patch:
  [1] https://codereview.chromium.org/1078783002/
  [2] https://codereview.chromium.org/1071203002/
  [3] This CL.

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193940

[Peter Beverloo, 2015-04-09 16:20:14]

peter@chromium.org changed reviewers:
+ johnme@chromium.org, mkwst@chromium.org

[Peter Beverloo, 2015-04-09 16:20:15]

... aaand here it goes again. :-)

PTAL

[johnme, 2015-04-10 11:07:51]

lgtm modulo comment

https://codereview.chromium.org/1072873002/diff/1/Source/modules/notification...
File Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
(right):

https://codereview.chromium.org/1072873002/diff/1/Source/modules/notification...
Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp:41:
notifications.append(Notification::create(resolver->executionContext(),
notificationInfo.persistentId, notificationInfo.data));
Shouldn't part 1 (https://codereview.chromium.org/1078783002) have added code to
use either persistentNotificationId or persistentId depending on which is set;
and then this patch could remove that code again?

[Mike West, 2015-04-10 11:12:45]

LGTM.

[Peter Beverloo, 2015-04-10 11:14:09]

Thanks!

https://codereview.chromium.org/1072873002/diff/1/Source/modules/notification...
File Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
(right):

https://codereview.chromium.org/1072873002/diff/1/Source/modules/notification...
Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp:41:
notifications.append(Notification::create(resolver->executionContext(),
notificationInfo.persistentId, notificationInfo.data));
On 2015/04/10 11:07:51, johnme wrote:
> Shouldn't part 1 (https://codereview.chromium.org/1078783002) have added code
to
> use either persistentNotificationId or persistentId depending on which is set;
> and then this patch could remove that code again?

Nothing is using this code path yet because the Chromium-side of
getNotifications() is blocked on https://codereview.chromium.org/1057573002/,
which is blocked on the integration patch, so we're all good here.

[Peter Beverloo, 2015-04-17 11:02:06]

The CQ bit was checked by peter@chromium.org

[commit-bot: I haz the power, 2015-04-17 11:02:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072873002/1

[commit-bot: I haz the power, 2015-04-17 12:36:51]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193940