Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1295)

Unified Diff: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

Issue 1072873002: Clean up Blink left-overs of textual persistent notification ids. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/notifications/Notification.cpp ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
diff --git a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
index 0c794f1ad1e6e7285ee136107d920ff342b95d53..4422629a7bba63d003300e61515db07abccdaddb 100644
--- a/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
+++ b/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
@@ -38,7 +38,7 @@ public:
HeapVector<Member<Notification>> notifications;
for (const WebPersistentNotificationInfo& notificationInfo : *notificationInfos)
- notifications.append(Notification::create(resolver->executionContext(), notificationInfo.persistentNotificationId, notificationInfo.data));
+ notifications.append(Notification::create(resolver->executionContext(), notificationInfo.persistentId, notificationInfo.data));
johnme 2015/04/10 11:07:51 Shouldn't part 1 (https://codereview.chromium.org/
Peter Beverloo 2015/04/10 11:14:09 Nothing is using this code path yet because the Ch
return notifications;
}
« no previous file with comments | « Source/modules/notifications/Notification.cpp ('k') | Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698