Clean up Blink left-overs of textual persistent notification ids.

Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/notifications/ServiceWorkerRegistrationNotifications.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
@@ skipping 20 matching lines @@
 class NotificationArray {
 public:
     using WebType = WebVector<WebPersistentNotificationInfo>;
 
     static HeapVector<Member<Notification>> take(ScriptPromiseResolver* resolver, WebType* notificationInfosRaw)
     {
         OwnPtr<WebType> notificationInfos = adoptPtr(notificationInfosRaw);
         HeapVector<Member<Notification>> notifications;
 
         for (const WebPersistentNotificationInfo& notificationInfo : *notificationInfos)
-            notifications.append(Notification::create(resolver->executionContext(), notificationInfo.persistentNotificationId, notificationInfo.data));
+            notifications.append(Notification::create(resolver->executionContext(), notificationInfo.persistentId, notificationInfo.data));

[johnme, 2015/04/10 11:07:51]

Shouldn't part 1 (https://codereview.chromium.org/1078783002) have added code to
use either persistentNotificationId or persistentId depending on which is set;
and then this patch could remove that code again?

[Peter Beverloo, 2015/04/10 11:14:09]

Nothing is using this code path yet because the Chromium-side of
getNotifications() is blocked on https://codereview.chromium.org/1057573002/,
which is blocked on the integration patch, so we're all good here.

 
         return notifications;
     }
 
     static void dispose(WebType* notificationInfosRaw)
     {
         delete notificationInfosRaw;
     }
 
 private:
@@ skipping 58 matching lines @@
     WebNotificationGetCallbacks* callbacks = new CallbackPromiseAdapter<NotificationArray, void>(resolver);
 
     WebNotificationManager* notificationManager = Platform::current()->notificationManager();
     ASSERT(notificationManager);
 
     notificationManager->getNotifications(options.tag(), serviceWorkerRegistration.webRegistration(), callbacks);
     return promise;
 }
 
 } // namespace blink