Issue 1070243003: [Effen] Use a Style element instead of inline style for the Text fn node's sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1070243003: [Effen] Use a Style element instead of inline style for the Text fn node's sky (Closed)

Created:
5 years, 8 months ago by Hixie

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

[Effen] Use a Style element instead of inline style for the Text fn node's sky element with display:paragraph, so that the C++ side shares RenderStyles. (based on review comments on https://codereview.chromium.org/1078973002 ) R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/808bd8bf2f6e969c9aabbee674b165e4ec52e70b

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	sky/framework/fn.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (1 generated)

Hixie

5 years, 8 months ago (2015-04-09 23:00:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
808bd8bf2f6e969c9aabbee674b165e4ec52e70b (presubmit successful).