Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: sky/framework/fn.dart

Issue 1070243003: [Effen] Use a Style element instead of inline style for the Text fn node's sky (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/framework/fn.dart
diff --git a/sky/framework/fn.dart b/sky/framework/fn.dart
index a63e521701cc6e059602f3ab5f81108423d17c2e..65389e56884d1eb576a6b62220f562e7ab00b72e 100644
--- a/sky/framework/fn.dart
+++ b/sky/framework/fn.dart
@@ -351,10 +351,12 @@ class Text extends SkyNodeWrapper {
SkyNodeWrapper get _emptyNode => _emptyText;
+ static final Style _displayParagraph = new Style('display:paragraph');
+
sky.Node _createNode() {
return sky.document.createElement('div')
..setChild(new sky.Text(this.data))
- ..setAttribute('style', 'display:paragraph');
+ ..setAttribute('class', _displayParagraph._className);
}
void _syncNode(SkyNodeWrapper old) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698