Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1078973002: [Effen] make fn wrap text in display:paragraph nodes (Closed)

Created:
5 years, 8 months ago by Hixie
Modified:
5 years, 8 months ago
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M sky/framework/fn.dart View 1 chunk +4 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (3 generated)
eseidel
lgtm
5 years, 8 months ago (2015-04-09 22:36:51 UTC) #2
Hixie
Committed patchset #1 (id:1) manually as 229494a16c0f8854d1cdc2587b3da5cfb052e86c (presubmit successful).
5 years, 8 months ago (2015-04-09 22:47:40 UTC) #3
abarth-chromium
https://codereview.chromium.org/1078973002/diff/1/sky/framework/fn.dart File sky/framework/fn.dart (right): https://codereview.chromium.org/1078973002/diff/1/sky/framework/fn.dart#newcode357 sky/framework/fn.dart:357: ..setAttribute('style', 'display:paragraph'); We should do this with a class ...
5 years, 8 months ago (2015-04-09 22:48:45 UTC) #5
Hixie
On 2015/04/09 at 22:48:45, abarth wrote: > https://codereview.chromium.org/1078973002/diff/1/sky/framework/fn.dart > File sky/framework/fn.dart (right): > > https://codereview.chromium.org/1078973002/diff/1/sky/framework/fn.dart#newcode357 ...
5 years, 8 months ago (2015-04-09 22:58:18 UTC) #6
jamesr
5 years, 8 months ago (2015-04-10 00:25:32 UTC) #8
Message was sent while issue was closed. 
framework/basic.sky seems to be consistently failing on the bots after this
(instead of inconsistently flaking beforehand)

Powered by Google App Engine
This is Rietveld 408576698