Issue 106983007: Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 106983007: Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>) (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>) Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>). Calls have either been replaced by the new toWebCoreString(v8::String) or by the V8TRYCATCH_FOR_V8STRINGRESOURCE*() macros in cases where it can throw an exception. R=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163488

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -16 lines)			Patch
M	Source/bindings/v8/V8Binding.h	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	Source/bindings/v8/V8Initializer.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/bindings/v8/WorkerScriptController.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8BiquadFilterNodeCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8OscillatorNodeCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/custom/V8PannerNodeCustom.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/custom/V8WindowCustom.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/106983007/1

7 years ago (2013-12-10 02:26:35 UTC) #3

Message was sent while issue was closed.

Change committed as 163488

Expand Messages | Collapse Messages