Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: Source/bindings/v8/V8Binding.h

Issue 106983007: Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8Binding.h
diff --git a/Source/bindings/v8/V8Binding.h b/Source/bindings/v8/V8Binding.h
index 49d120fdc37c8b30e1564f9181acfb077f2df353..a20f8a001537e7f0519fd6f843a4a29d01ef3088 100644
--- a/Source/bindings/v8/V8Binding.h
+++ b/Source/bindings/v8/V8Binding.h
@@ -187,15 +187,6 @@ namespace WebCore {
// FIXME: Replace all the call sites with V8TRYCATCH_FOR_V8STRINGRESOURCE().
// Using this method will lead to a wrong behavior, because you cannot stop the
// execution when an exception is thrown inside stringResource.prepare().
- inline String toWebCoreString(v8::Handle<v8::Value> value)
- {
- V8StringResource<> stringResource(value);
- if (!stringResource.prepare())
- return String();
- return stringResource;
- }
-
- // FIXME: See the above comment.
inline String toWebCoreStringWithNullCheck(v8::Handle<v8::Value> value)
{
V8StringResource<WithNullCheck> stringResource(value);
« no previous file with comments | « no previous file | Source/bindings/v8/V8Initializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698