Source/bindings/v8/custom/V8WindowCustom.cpp - Issue 106983007: Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8WindowCustom.cpp

Issue 106983007: Get rid of last uses of deprecated toWebCoreString(v8::Handle<v8::Value>) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/v8/custom/V8WindowCustom.cpp

diff --git a/Source/bindings/v8/custom/V8WindowCustom.cpp b/Source/bindings/v8/custom/V8WindowCustom.cpp

index 0b67b777cff0adde1db81e8ca78d91544d9ad1e7..c21dbd5222e98d23f2455890c7cc622343e1d5e4 100644

--- a/Source/bindings/v8/custom/V8WindowCustom.cpp

+++ b/Source/bindings/v8/custom/V8WindowCustom.cpp

@@ -95,7 +95,7 @@ void WindowSetTimeoutImpl(const v8::FunctionCallbackInfo<v8::Value>& info, bool

if (function->IsString()) {

functionString = toWebCoreString(function.As<v8::String>());

} else {

- v8::Handle<v8::Value> v8String = function->ToString();

+ v8::Handle<v8::String> v8String = function->ToString();

// Bail out if string conversion failed.

if (v8String.IsEmpty())

« no previous file with comments | « Source/bindings/v8/custom/V8PannerNodeCustom.cpp ('k') | no next file » | no next file with comments »