Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 1069683002: [ia32] Introduce BMI instructions. (Closed)

Created:
5 years, 8 months ago by Jing
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Introduce BMI instructions. BUG=v8:4015 LOG=n Committed: https://crrev.com/dba47f6486ecb381de836cbac9a54be75c62cf71 Cr-Commit-Position: refs/heads/master@{#27683}

Patch Set 1 #

Patch Set 2 : Align with gdb disassembler #

Unified diffs Side-by-side diffs Delta from patch set Stats (+708 lines, -8 lines) Patch
M src/ia32/assembler-ia32.h View 3 chunks +93 lines, -2 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 1 5 chunks +82 lines, -5 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 4 chunks +122 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +5 lines, -1 line 0 comments Download
M test/cctest/test-assembler-ia32.cc View 1 chunk +346 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jing
5 years, 8 months ago (2015-04-09 02:46:37 UTC) #2
Benedikt Meurer
LGTM, thanks.
5 years, 8 months ago (2015-04-09 04:56:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1069683002/20001
5 years, 8 months ago (2015-04-09 04:56:39 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-09 06:50:57 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 06:51:12 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dba47f6486ecb381de836cbac9a54be75c62cf71
Cr-Commit-Position: refs/heads/master@{#27683}

Powered by Google App Engine
This is Rietveld 408576698