Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1192)

Unified Diff: content/content_shell.gypi

Issue 1069433002: Don't #define snprintf in VS 2015 builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix snprintf definition for libexif also. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/libexif/libexif.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/content_shell.gypi
diff --git a/content/content_shell.gypi b/content/content_shell.gypi
index 8c32ab7dc00ee2b20735c9fba33cd64093e2bb4e..5df6def21cf75705fb0287ddf52d6e06bf82ca6b 100644
--- a/content/content_shell.gypi
+++ b/content/content_shell.gypi
@@ -743,9 +743,14 @@
'dependencies': [ '../build/linux/system.gyp:x11' ],
}],
['OS=="win"', {
- 'defines': [
- # This seems like a hack, but this is what Safari Win does.
- 'snprintf=_snprintf',
+ 'conditions': [
+ ['MSVS_VERSION < "2015"', {
+ 'defines': [
+ # This seems like a hack, but this is what Safari Win does.
+ # Luckily it is no longer needed/allowed with VS 2015.
+ 'snprintf=_snprintf',
+ ],
+ }],
],
'sources': [
'shell/tools/plugin/win/TestNetscapePlugin.def',
« no previous file with comments | « no previous file | third_party/libexif/libexif.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698