Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: third_party/libexif/libexif.gyp

Issue 1069433002: Don't #define snprintf in VS 2015 builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix snprintf definition for libexif also. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libexif/libexif.gyp
diff --git a/third_party/libexif/libexif.gyp b/third_party/libexif/libexif.gyp
index 5b7b452d33756e6c1c530f33c174cfc8d97b3e2a..2d8b2428226894d6140f2aaa4e4d5a04b7e98ba5 100644
--- a/third_party/libexif/libexif.gyp
+++ b/third_party/libexif/libexif.gyp
@@ -83,9 +83,16 @@
'sources': [
'libexif.def',
],
+ 'conditions': [
+ ['MSVS_VERSION < "2015"', {
+ 'defines': [
+ # This seems like a hack, but this is what Safari Win does.
+ # Luckily it is no longer needed/allowed with VS 2015.
+ 'snprintf=_snprintf',
+ ],
+ }],
+ ],
'defines': [
- # This seems like a hack, but this is what WebKit Win does.
- 'snprintf=_snprintf',
'inline=__inline',
],
'msvs_disabled_warnings': [
« no previous file with comments | « content/content_shell.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698