Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: content/content_shell.gypi

Issue 1069433002: Don't #define snprintf in VS 2015 builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix snprintf definition for libexif also. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/libexif/libexif.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'content_shell_product_name': 'Content Shell', 7 'content_shell_product_name': 'Content Shell',
8 # The "19" is so that sites that sniff for version think that this is 8 # The "19" is so that sites that sniff for version think that this is
9 # something reasonably current; the "77.34.5" is a hint that this isn't a 9 # something reasonably current; the "77.34.5" is a hint that this isn't a
10 # standard Chrome. 10 # standard Chrome.
(...skipping 725 matching lines...) Expand 10 before | Expand all | Expand 10 after
736 }], 736 }],
737 ['os_posix == 1 and OS != "mac"', { 737 ['os_posix == 1 and OS != "mac"', {
738 'cflags': [ 738 'cflags': [
739 '-fvisibility=default', 739 '-fvisibility=default',
740 ], 740 ],
741 }], 741 }],
742 ['use_x11 == 1', { 742 ['use_x11 == 1', {
743 'dependencies': [ '../build/linux/system.gyp:x11' ], 743 'dependencies': [ '../build/linux/system.gyp:x11' ],
744 }], 744 }],
745 ['OS=="win"', { 745 ['OS=="win"', {
746 'defines': [ 746 'conditions': [
747 # This seems like a hack, but this is what Safari Win does. 747 ['MSVS_VERSION < "2015"', {
748 'snprintf=_snprintf', 748 'defines': [
749 # This seems like a hack, but this is what Safari Win does.
750 # Luckily it is no longer needed/allowed with VS 2015.
751 'snprintf=_snprintf',
752 ],
753 }],
749 ], 754 ],
750 'sources': [ 755 'sources': [
751 'shell/tools/plugin/win/TestNetscapePlugin.def', 756 'shell/tools/plugin/win/TestNetscapePlugin.def',
752 'shell/tools/plugin/win/TestNetscapePlugin.rc', 757 'shell/tools/plugin/win/TestNetscapePlugin.rc',
753 ], 758 ],
754 # The .rc file requires that the name of the dll is np_test_netscape_p lugin.dll. 759 # The .rc file requires that the name of the dll is np_test_netscape_p lugin.dll.
755 'product_name': 'np_test_netscape_plugin', 760 'product_name': 'np_test_netscape_plugin',
756 # Disable c4267 warnings until we fix size_t to int truncations. 761 # Disable c4267 warnings until we fix size_t to int truncations.
757 'msvs_disabled_warnings': [ 4267, ], 762 'msvs_disabled_warnings': [ 4267, ],
758 }], 763 }],
(...skipping 400 matching lines...) Expand 10 before | Expand all | Expand 10 after
1159 '--input_symbol', '<(PRODUCT_DIR)/content_shell.exe.pdb', 1164 '--input_symbol', '<(PRODUCT_DIR)/content_shell.exe.pdb',
1160 '--destination_dir', '<(dest_dir)', 1165 '--destination_dir', '<(dest_dir)',
1161 ], 1166 ],
1162 }, 1167 },
1163 ], 1168 ],
1164 }, 1169 },
1165 ], 1170 ],
1166 }], # OS=="win" and fastbuild==0 and target_arch=="ia32" 1171 }], # OS=="win" and fastbuild==0 and target_arch=="ia32"
1167 ] 1172 ]
1168 } 1173 }
OLDNEW
« no previous file with comments | « no previous file | third_party/libexif/libexif.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698