Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1068663002: gpu: More specific internalformat requirements for CreateImageCHROMIUM. (Closed)

Created:
5 years, 8 months ago by reveman
Modified:
5 years, 8 months ago
Reviewers:
piman
CC:
cc-bugs_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mcasas+watch_chromium.org, miu+watch_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, sievers+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: More specific internalformat requirements for CreateImageCHROMIUM. This reduces the complexity of the code needed to validate internalformat and makes it easier to add new formats. BUG=474280 TEST=gl_tests --gtest_filter=GpuMemoryBufferTests/GpuMemoryBufferTest.Lifecycle/* Committed: https://crrev.com/8df6cbdec670ba20e6f11c9cd6d1d3971a4c518c Cr-Commit-Position: refs/heads/master@{#324007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -47 lines) Patch
M cc/resources/resource_provider.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_texture_wrapper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt View 4 chunks +9 lines, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/image_factory.cc View 2 chunks +3 lines, -35 lines 0 comments Download
M gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
reveman
5 years, 8 months ago (2015-04-07 01:35:57 UTC) #2
piman
lgtm
5 years, 8 months ago (2015-04-07 02:45:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068663002/1
5 years, 8 months ago (2015-04-07 02:56:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 03:00:03 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 03:00:56 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8df6cbdec670ba20e6f11c9cd6d1d3971a4c518c
Cr-Commit-Position: refs/heads/master@{#324007}

Powered by Google App Engine
This is Rietveld 408576698