content/common/gpu/client/command_buffer_proxy_impl.cc - Issue 1068663002: gpu: More specific internalformat requirements for CreateImageCHROMIUM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/command_buffer_proxy_impl.cc

Issue 1068663002: gpu: More specific internalformat requirements for CreateImageCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_texture_wrapper.cc ('k') | gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/command_buffer_proxy_impl.cc

diff --git a/content/common/gpu/client/command_buffer_proxy_impl.cc b/content/common/gpu/client/command_buffer_proxy_impl.cc

index 988dbd52f91a50e4acfd4904e2cff683e250f50e..257e084645ca7261fcdf0473c28e505b49fa5fa4 100644

--- a/content/common/gpu/client/command_buffer_proxy_impl.cc

+++ b/content/common/gpu/client/command_buffer_proxy_impl.cc

@@ -373,6 +373,8 @@ int32_t CommandBufferProxyImpl::CreateImage(ClientBuffer buffer,

channel_->ShareGpuMemoryBufferToGpuProcess(gpu_memory_buffer->GetHandle(),

&requires_sync_point);

+ DCHECK(gpu::ImageFactory::IsGpuMemoryBufferFormatSupported(

+ gpu_memory_buffer->GetFormat(), capabilities_));

DCHECK(gpu::ImageFactory::IsImageSizeValidForGpuMemoryBufferFormat(

gfx::Size(width, height), gpu_memory_buffer->GetFormat()));

DCHECK(gpu::ImageFactory::IsImageFormatCompatibleWithGpuMemoryBufferFormat(