gpu: More specific internalformat requirements for CreateImageCHROMIUM.

gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2chromium.h>
 #include <GLES2/gl2ext.h>
 #include <GLES2/gl2extchromium.h>
 
 #include "base/bind.h"
@@ skipping 108 matching lines @@
     case gfx::GpuMemoryBuffer::ETC1:
     case gfx::GpuMemoryBuffer::RGBX_8888:
       NOTREACHED();
       return std::vector<uint8>();
   }
 
   NOTREACHED();
   return std::vector<uint8>();
 }
 
-GLenum TextureFormat(gfx::GpuMemoryBuffer::Format format) {
+GLenum InternalFormat(gfx::GpuMemoryBuffer::Format format) {
   switch (format) {
     case gfx::GpuMemoryBuffer::RGBA_8888:
       return GL_RGBA;
     case gfx::GpuMemoryBuffer::BGRA_8888:
       return GL_BGRA_EXT;
     case gfx::GpuMemoryBuffer::ATC:
     case gfx::GpuMemoryBuffer::ATCIA:
     case gfx::GpuMemoryBuffer::DXT1:
     case gfx::GpuMemoryBuffer::DXT5:
     case gfx::GpuMemoryBuffer::ETC1:
@@ skipping 30 matching lines @@
     for (int x = 0; x < kImageWidth; ++x) {
       std::copy(pixel.begin(), pixel.end(),
                 mapped_buffer + y * stride + x * pixel.size());
     }
   }
 
   // Unmap the buffer.
   buffer->Unmap();
 
   // Create the image. This should add the image ID to the ImageManager.
-  GLuint image_id = glCreateImageCHROMIUM(
-      buffer->AsClientBuffer(), kImageWidth, kImageHeight, GL_RGBA);
+  GLuint image_id =
+      glCreateImageCHROMIUM(buffer->AsClientBuffer(), kImageWidth, kImageHeight,
+                            InternalFormat(GetParam()));
   EXPECT_NE(0u, image_id);
   EXPECT_TRUE(gl_.decoder()->GetImageManager()->LookupImage(image_id) != NULL);
 
   // Bind the texture and the image.
   glBindTexture(GL_TEXTURE_2D, texture_ids_[0]);
   glBindTexImage2DCHROMIUM(GL_TEXTURE_2D, image_id);
 
   // Copy texture so we can verify result using CheckPixels.
   glCopyTextureCHROMIUM(GL_TEXTURE_2D, texture_ids_[0], texture_ids_[1],
-                        TextureFormat(GetParam()), GL_UNSIGNED_BYTE);
+                        InternalFormat(GetParam()), GL_UNSIGNED_BYTE);
   EXPECT_TRUE(glGetError() == GL_NO_ERROR);
 
   // Check if pixels match the values that were assigned to the mapped buffer.
   GLTestHelper::CheckPixels(0, 0, kImageWidth, kImageHeight, 0,
                             &GetFramebufferPixel(GetParam()).front());
   EXPECT_TRUE(GL_NO_ERROR == glGetError());
 
   // Release the image.
   glReleaseTexImage2DCHROMIUM(GL_TEXTURE_2D, image_id);
 
   // Destroy the image.
   glDestroyImageCHROMIUM(image_id);
 }
 
 INSTANTIATE_TEST_CASE_P(GpuMemoryBufferTests,
                         GpuMemoryBufferTest,
                         ::testing::Values(gfx::GpuMemoryBuffer::RGBA_8888,
                                           gfx::GpuMemoryBuffer::BGRA_8888));
 
 }  // namespace gles2
 }  // namespace gpu