Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 1068503002: Skia: Replace get_uploaded_hashes call with inline script (Closed)

Created:
5 years, 8 months ago by borenet
Modified:
5 years, 8 months ago
Reviewers:
jcgregorio, mtklein
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Skia: Replace get_uploaded_hashes call with inline script BUG=skia:3521 TBR=rmistry Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294694

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -72 lines) Patch
M scripts/slave/recipe_modules/skia/api.py View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Nexus5-GPU-Adreno330-Arm7-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-NexusPlayer-GPU-PowerVR-x86-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-Xoom-GPU-Tegra2-Arm7-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Daisy-CPU-NEON-Arm7-Release.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Link-CPU-AVX-x86_64-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Debug-ZeroGPUCache.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release-ANGLE.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win8-MSVC-ShuttleA-CPU-AVX-x86_64-Debug.json View 1 chunk +15 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_dm.json View 1 chunk +15 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
borenet
This replaces https://codereview.chromium.org/1066603002/
5 years, 8 months ago (2015-04-06 19:33:01 UTC) #2
jcgregorio
lgtm
5 years, 8 months ago (2015-04-06 19:36:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068503002/1
5 years, 8 months ago (2015-04-06 19:40:01 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-04-06 19:40:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1068503002/1
5 years, 8 months ago (2015-04-06 19:43:52 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 19:46:34 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294694

Powered by Google App Engine
This is Rietveld 408576698