scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json - Issue 1068503002: Skia: Replace get_uploaded_hashes call with inline script

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json

Issue 1068503002: Skia: Replace get_uploaded_hashes call with inline script (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Debug-ZeroGPUCache.json ('k') | scripts/slave/recipes/skia/skia.expected/Test-Win7-MSVC-ShuttleA-GPU-HD2000-x86-Release.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json

diff --git a/scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json b/scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json

index b4b26e35f47044889fad7b8c1456dc7a498291c8..f342c9e49269a3b05895a69cfd4c57bca823d588 100644

--- a/scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json

+++ b/scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json

@@ -319,13 +319,24 @@

"cmd": [

"python",

"-u",

- "[SLAVE_BUILD]/skia/tools/get_uploaded_hashes.py",

- "chromium-skia-gm",

- "dm-images-v1",

+ "\nimport contextlib\nimport sys\nimport urllib2\n\nHASHES_URL = 'https://gold.skia.org/2/_/hashes'\n\nwith open(sys.argv[1], 'w') as f:\n with contextlib.closing(urllib2.urlopen(HASHES_URL)) as w:\n f.write(w.read())\n",

"[SLAVE_BUILD]/tmp/uninteresting_hashes.txt"

"cwd": "[SLAVE_BUILD]/skia",

- "name": "get uninteresting hashes"

+ "name": "get uninteresting hashes",

+ "~followup_annotations": [

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@import contextlib@@@",

+ "@@@STEP_LOG_LINE@python.inline@import sys@@@",

+ "@@@STEP_LOG_LINE@python.inline@import urllib2@@@",

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@HASHES_URL = 'https://gold.skia.org/2/_/hashes'@@@",

+ "@@@STEP_LOG_LINE@python.inline@@@@",

+ "@@@STEP_LOG_LINE@python.inline@with open(sys.argv[1], 'w') as f:@@@",

+ "@@@STEP_LOG_LINE@python.inline@ with contextlib.closing(urllib2.urlopen(HASHES_URL)) as w:@@@",

+ "@@@STEP_LOG_LINE@python.inline@ f.write(w.read())@@@",

+ "@@@STEP_LOG_END@python.inline@@@"

+ ]

{

"cmd": [