Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(993)

Unified Diff: scripts/slave/recipe_modules/skia/api.py

Issue 1068503002: Skia: Replace get_uploaded_hashes call with inline script (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Debug.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/skia/api.py
diff --git a/scripts/slave/recipe_modules/skia/api.py b/scripts/slave/recipe_modules/skia/api.py
index 6c274e974f0ddb2b017fbaf13bcc2c1b27e3de58..810afa2a2843e500b508a192cd185374132d3e49 100644
--- a/scripts/slave/recipe_modules/skia/api.py
+++ b/scripts/slave/recipe_modules/skia/api.py
@@ -274,10 +274,21 @@ class SkiaApi(recipe_api.RecipeApi):
hash_filename = 'uninteresting_hashes.txt'
self.m.path.makedirs('tmp_dir', self.tmp_dir)
host_hashes_file = self.tmp_dir.join(hash_filename)
- self.m.python('get uninteresting hashes',
- script=self.skia_dir.join('tools', 'get_uploaded_hashes.py'),
- args=['chromium-skia-gm', 'dm-images-v1', host_hashes_file],
- cwd=self.skia_dir)
+ self.m.python.inline(
+ 'get uninteresting hashes',
+ """
+ import contextlib
+ import sys
+ import urllib2
+
+ HASHES_URL = 'https://gold.skia.org/2/_/hashes'
+
+ with open(sys.argv[1], 'w') as f:
+ with contextlib.closing(urllib2.urlopen(HASHES_URL)) as w:
+ f.write(w.read())
+ """,
+ args=[host_hashes_file],
+ cwd=self.skia_dir)
if isinstance(self.device_dirs.tmp_dir, basestring):
hashes_file = self.device_dirs.tmp_dir + '/' + hash_filename
else:
« no previous file with comments | « no previous file | scripts/slave/recipes/skia/skia.expected/Test-Android-GCC-GalaxyS4-GPU-SGX544-Arm7-Debug.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698