Issue 106793006: Refactoring: Remove an uneeded argment from TranslateBubbleView::TranslateBubbleView

Issue 106793006: Refactoring: Remove an uneeded argment from TranslateBubbleView::TranslateBubbleView (Closed)

Created:
7 years ago by hajimehoshi

Modified:
7 years ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, Avi (use Gerrit), creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Refactoring: Remove an uneeded argment from TranslateBubbleView::TranslateBubbleView We can use a WebContent to open a new tab instead of a Browser. TEST=unit_tests --gtest_filter=TranslateBubbleViewTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242077

Patch Set 1 : #

Total comments: 4

Patch Set 2 : sky's review #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -17 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/translate/translate_bubble_view.h	View	1	4 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ui/views/translate/translate_bubble_view.cc	View	1	6 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/ui/views/translate/translate_bubble_view_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM https://codereview.chromium.org/106793006/diff/20001/chrome/browser/ui/views/translate/translate_bubble_view.cc File chrome/browser/ui/views/translate/translate_bubble_view.cc (right): https://codereview.chromium.org/106793006/diff/20001/chrome/browser/ui/views/translate/translate_bubble_view.cc#newcode21 chrome/browser/ui/views/translate/translate_bubble_view.cc:21: #include "chrome/browser/ui/browser.h" Is this include needed anymore? https://codereview.chromium.org/106793006/diff/20001/chrome/browser/ui/views/translate/translate_bubble_view.h ...

7 years ago (2013-12-19 16:45:20 UTC) #2

hajimehoshi

Thank you! https://codereview.chromium.org/106793006/diff/20001/chrome/browser/ui/views/translate/translate_bubble_view.cc File chrome/browser/ui/views/translate/translate_bubble_view.cc (right): https://codereview.chromium.org/106793006/diff/20001/chrome/browser/ui/views/translate/translate_bubble_view.cc#newcode21 chrome/browser/ui/views/translate/translate_bubble_view.cc:21: #include "chrome/browser/ui/browser.h" On 2013/12/19 16:45:21, sky (OOO ...

7 years ago (2013-12-20 03:25:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/106793006/40001

7 years ago (2013-12-20 03:27:18 UTC) #4

Message was sent while issue was closed.

Change committed as 242077

Expand Messages | Collapse Messages