Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Side by Side Diff: chrome/browser/ui/views/translate/translate_bubble_view.cc

Issue 106793006: Refactoring: Remove an uneeded argment from TranslateBubbleView::TranslateBubbleView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sky's review Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h" 5 #include "chrome/browser/ui/views/translate/translate_bubble_view.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
11 #include "base/i18n/string_compare.h" 11 #include "base/i18n/string_compare.h"
12 #include "base/memory/singleton.h" 12 #include "base/memory/singleton.h"
13 #include "base/metrics/histogram.h" 13 #include "base/metrics/histogram.h"
14 #include "base/prefs/pref_service.h" 14 #include "base/prefs/pref_service.h"
15 #include "base/strings/utf_string_conversions.h" 15 #include "base/strings/utf_string_conversions.h"
16 #include "chrome/browser/browser_process.h" 16 #include "chrome/browser/browser_process.h"
17 #include "chrome/browser/profiles/profile.h" 17 #include "chrome/browser/profiles/profile.h"
18 #include "chrome/browser/translate/translate_manager.h" 18 #include "chrome/browser/translate/translate_manager.h"
19 #include "chrome/browser/translate/translate_tab_helper.h" 19 #include "chrome/browser/translate/translate_tab_helper.h"
20 #include "chrome/browser/translate/translate_ui_delegate.h" 20 #include "chrome/browser/translate/translate_ui_delegate.h"
21 #include "chrome/browser/ui/browser.h"
22 #include "chrome/browser/ui/translate/translate_bubble_model_impl.h" 21 #include "chrome/browser/ui/translate/translate_bubble_model_impl.h"
23 #include "chrome/common/url_constants.h" 22 #include "chrome/common/url_constants.h"
24 #include "content/public/browser/web_contents.h" 23 #include "content/public/browser/web_contents.h"
25 #include "grit/generated_resources.h" 24 #include "grit/generated_resources.h"
26 #include "ui/base/l10n/l10n_util.h" 25 #include "ui/base/l10n/l10n_util.h"
27 #include "ui/base/models/combobox_model.h" 26 #include "ui/base/models/combobox_model.h"
28 #include "ui/base/resource/resource_bundle.h" 27 #include "ui/base/resource/resource_bundle.h"
29 #include "ui/views/controls/button/checkbox.h" 28 #include "ui/views/controls/button/checkbox.h"
30 #include "ui/views/controls/button/label_button.h" 29 #include "ui/views/controls/button/label_button.h"
31 #include "ui/views/controls/combobox/combobox.h" 30 #include "ui/views/controls/combobox/combobox.h"
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 // the child view is destructed. For example, |source_language_combobx_model_| 131 // the child view is destructed. For example, |source_language_combobx_model_|
133 // is referred by Combobox's destructor. Before destroying the models, 132 // is referred by Combobox's destructor. Before destroying the models,
134 // removing the child views is needed. 133 // removing the child views is needed.
135 RemoveAllChildViews(true); 134 RemoveAllChildViews(true);
136 } 135 }
137 136
138 // static 137 // static
139 void TranslateBubbleView::ShowBubble(views::View* anchor_view, 138 void TranslateBubbleView::ShowBubble(views::View* anchor_view,
140 content::WebContents* web_contents, 139 content::WebContents* web_contents,
141 TranslateBubbleModel::ViewState type, 140 TranslateBubbleModel::ViewState type,
142 TranslateErrors::Type error_type, 141 TranslateErrors::Type error_type) {
143 Browser* browser) {
144 // During auto-translating, the bubble should not be shown. 142 // During auto-translating, the bubble should not be shown.
145 if (type == TranslateBubbleModel::VIEW_STATE_TRANSLATING || 143 if (type == TranslateBubbleModel::VIEW_STATE_TRANSLATING ||
146 type == TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE) { 144 type == TranslateBubbleModel::VIEW_STATE_AFTER_TRANSLATE) {
147 TranslateTabHelper* translate_tab_helper = 145 TranslateTabHelper* translate_tab_helper =
148 TranslateTabHelper::FromWebContents(web_contents); 146 TranslateTabHelper::FromWebContents(web_contents);
149 if (!translate_tab_helper || 147 if (!translate_tab_helper ||
150 translate_tab_helper->language_state().InTranslateNavigation()) { 148 translate_tab_helper->language_state().InTranslateNavigation()) {
151 return; 149 return;
152 } 150 }
153 } 151 }
(...skipping 17 matching lines...) Expand all
171 std::string target_language; 169 std::string target_language;
172 GetTranslateLanguages(web_contents, &source_language, &target_language); 170 GetTranslateLanguages(web_contents, &source_language, &target_language);
173 171
174 scoped_ptr<TranslateUIDelegate> ui_delegate( 172 scoped_ptr<TranslateUIDelegate> ui_delegate(
175 new TranslateUIDelegate(web_contents, source_language, target_language)); 173 new TranslateUIDelegate(web_contents, source_language, target_language));
176 scoped_ptr<TranslateBubbleModel> model( 174 scoped_ptr<TranslateBubbleModel> model(
177 new TranslateBubbleModelImpl(type, ui_delegate.Pass())); 175 new TranslateBubbleModelImpl(type, ui_delegate.Pass()));
178 TranslateBubbleView* view = new TranslateBubbleView(anchor_view, 176 TranslateBubbleView* view = new TranslateBubbleView(anchor_view,
179 model.Pass(), 177 model.Pass(),
180 error_type, 178 error_type,
181 browser,
182 web_contents); 179 web_contents);
183 views::BubbleDelegateView::CreateBubble(view)->Show(); 180 views::BubbleDelegateView::CreateBubble(view)->Show();
184 } 181 }
185 182
186 // static 183 // static
187 bool TranslateBubbleView::IsShowing() { 184 bool TranslateBubbleView::IsShowing() {
188 return translate_bubble_view_ != NULL; 185 return translate_bubble_view_ != NULL;
189 } 186 }
190 187
191 // static 188 // static
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
318 } 315 }
319 316
320 TranslateBubbleModel::ViewState TranslateBubbleView::GetViewState() const { 317 TranslateBubbleModel::ViewState TranslateBubbleView::GetViewState() const {
321 return model_->GetViewState(); 318 return model_->GetViewState();
322 } 319 }
323 320
324 TranslateBubbleView::TranslateBubbleView( 321 TranslateBubbleView::TranslateBubbleView(
325 views::View* anchor_view, 322 views::View* anchor_view,
326 scoped_ptr<TranslateBubbleModel> model, 323 scoped_ptr<TranslateBubbleModel> model,
327 TranslateErrors::Type error_type, 324 TranslateErrors::Type error_type,
328 Browser* browser,
329 content::WebContents* web_contents) 325 content::WebContents* web_contents)
330 : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT), 326 : BubbleDelegateView(anchor_view, views::BubbleBorder::TOP_RIGHT),
331 WebContentsObserver(web_contents), 327 WebContentsObserver(web_contents),
332 before_translate_view_(NULL), 328 before_translate_view_(NULL),
333 translating_view_(NULL), 329 translating_view_(NULL),
334 after_translate_view_(NULL), 330 after_translate_view_(NULL),
335 error_view_(NULL), 331 error_view_(NULL),
336 advanced_view_(NULL), 332 advanced_view_(NULL),
337 denial_combobox_(NULL), 333 denial_combobox_(NULL),
338 source_language_combobox_(NULL), 334 source_language_combobox_(NULL),
339 target_language_combobox_(NULL), 335 target_language_combobox_(NULL),
340 always_translate_checkbox_(NULL), 336 always_translate_checkbox_(NULL),
341 advanced_cancel_button_(NULL), 337 advanced_cancel_button_(NULL),
342 advanced_done_button_(NULL), 338 advanced_done_button_(NULL),
343 model_(model.Pass()), 339 model_(model.Pass()),
344 error_type_(error_type), 340 error_type_(error_type),
345 is_in_incognito_window_( 341 is_in_incognito_window_(
346 web_contents ? 342 web_contents ?
347 web_contents->GetBrowserContext()->IsOffTheRecord() : false), 343 web_contents->GetBrowserContext()->IsOffTheRecord() : false),
348 browser_(browser),
349 translate_executed_(false), 344 translate_executed_(false),
350 denial_button_clicked_(false) { 345 denial_button_clicked_(false) {
351 if (model_->GetViewState() != 346 if (model_->GetViewState() !=
352 TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE) { 347 TranslateBubbleModel::VIEW_STATE_BEFORE_TRANSLATE) {
353 translate_executed_ = true; 348 translate_executed_ = true;
354 } 349 }
355 350
356 set_margins(gfx::Insets(views::kPanelVertMargin, views::kPanelHorizMargin, 351 set_margins(gfx::Insets(views::kPanelVertMargin, views::kPanelHorizMargin,
357 views::kPanelVertMargin, views::kPanelHorizMargin)); 352 views::kPanelVertMargin, views::kPanelHorizMargin));
358 353
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
425 void TranslateBubbleView::HandleLinkClicked( 420 void TranslateBubbleView::HandleLinkClicked(
426 TranslateBubbleView::LinkID sender_id) { 421 TranslateBubbleView::LinkID sender_id) {
427 switch (sender_id) { 422 switch (sender_id) {
428 case LINK_ID_ADVANCED: { 423 case LINK_ID_ADVANCED: {
429 SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED); 424 SwitchView(TranslateBubbleModel::VIEW_STATE_ADVANCED);
430 break; 425 break;
431 } 426 }
432 case LINK_ID_LANGUAGE_SETTINGS: { 427 case LINK_ID_LANGUAGE_SETTINGS: {
433 std::string url = std::string(chrome::kChromeUISettingsURL) + 428 std::string url = std::string(chrome::kChromeUISettingsURL) +
434 chrome::kLanguageOptionsSubPage; 429 chrome::kLanguageOptionsSubPage;
435 browser_->OpenURL(content::OpenURLParams( 430 web_contents()->OpenURL(content::OpenURLParams(
436 GURL(url), 431 GURL(url),
437 content::Referrer(), 432 content::Referrer(),
438 NEW_FOREGROUND_TAB, 433 NEW_FOREGROUND_TAB,
439 content::PAGE_TRANSITION_LINK, 434 content::PAGE_TRANSITION_LINK,
440 false)); 435 false));
441 break; 436 break;
442 } 437 }
443 } 438 }
444 } 439 }
445 440
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 model_->ShouldAlwaysTranslate()); 800 model_->ShouldAlwaysTranslate());
806 } 801 }
807 802
808 base::string16 label; 803 base::string16 label;
809 if (model_->IsPageTranslatedInCurrentLanguages()) 804 if (model_->IsPageTranslatedInCurrentLanguages())
810 label = l10n_util::GetStringUTF16(IDS_DONE); 805 label = l10n_util::GetStringUTF16(IDS_DONE);
811 else 806 else
812 label = l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ACCEPT); 807 label = l10n_util::GetStringUTF16(IDS_TRANSLATE_BUBBLE_ACCEPT);
813 advanced_done_button_->SetText(label); 808 advanced_done_button_->SetText(label);
814 } 809 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698