Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3306)

Unified Diff: chrome/browser/ui/views/translate/translate_bubble_view.h

Issue 106793006: Refactoring: Remove an uneeded argment from TranslateBubbleView::TranslateBubbleView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: sky's review Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/translate/translate_bubble_view.h
diff --git a/chrome/browser/ui/views/translate/translate_bubble_view.h b/chrome/browser/ui/views/translate/translate_bubble_view.h
index 3cb2e2b19f7a06aee4749c7ff36eb3b63374a5f7..9dcf4c3e5d4b64879992c556b4646072972c6716 100644
--- a/chrome/browser/ui/views/translate/translate_bubble_view.h
+++ b/chrome/browser/ui/views/translate/translate_bubble_view.h
@@ -18,7 +18,6 @@
#include "ui/views/controls/combobox/combobox_listener.h"
#include "ui/views/controls/link_listener.h"
-class Browser;
class PrefService;
class TranslateBubbleModel;
@@ -42,8 +41,7 @@ class TranslateBubbleView : public views::BubbleDelegateView,
static void ShowBubble(views::View* anchor_view,
content::WebContents* web_contents,
TranslateBubbleModel::ViewState type,
- TranslateErrors::Type error_type,
- Browser* browser);
+ TranslateErrors::Type error_type);
// If true, the Translate bubble is being shown.
static bool IsShowing();
@@ -121,7 +119,6 @@ class TranslateBubbleView : public views::BubbleDelegateView,
TranslateBubbleView(views::View* anchor_view,
scoped_ptr<TranslateBubbleModel> model,
TranslateErrors::Type error_type,
- Browser* browser,
content::WebContents* web_contents);
// Returns the current child view.
@@ -193,9 +190,6 @@ class TranslateBubbleView : public views::BubbleDelegateView,
// Whether the window is an incognito window.
const bool is_in_incognito_window_;
- // The browser to open the help URL into a new tab.
- Browser* browser_;
-
// Whether the translation is acutually executed.
bool translate_executed_;
« no previous file with comments | « chrome/browser/ui/views/frame/browser_view.cc ('k') | chrome/browser/ui/views/translate/translate_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698