Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 106793004: Revert of Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed)

Created:
7 years ago by Denis Kuznetsov (DE-MUC)
Modified:
7 years ago
CC:
chromium-reviews, skanuj+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, jar (doing other things), kkania, dominich, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, rpetterson, haitaol+watch_chromium.org, rouslan+spellwatch_chromium.org, dsinclair+watch_chromium.org, asvitkine+watch_chromium.org, Jered, donnd+watch_chromium.org, frankf, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, rsimha+watch_chromium.org, jshin+watch_chromium.org, inferno
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/100823007/ Reason for revert: This patchset breaks at least displayment of Russian localized strings on Chromeos login screen. TBR=mark@chromium.org,jshin@chromium.org,thakis@chromium.org,asanka@chromium.org,zea@chromium.org,bauerb@chromium.org,rsesek@chromium.org NOTREECHECKS=true NOTRY=true BUG=15466 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=240082

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+226 lines, -337 lines) Patch
M base/debug/trace_event_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/json/json_value_serializer_unittest.cc View 2 chunks +17 lines, -18 lines 0 comments Download
M base/json/json_writer.h View 3 chunks +17 lines, -4 lines 0 comments Download
M base/json/json_writer.cc View 6 chunks +23 lines, -9 lines 0 comments Download
M base/json/string_escape.h View 2 chunks +17 lines, -39 lines 0 comments Download
M base/json/string_escape.cc View 2 chunks +49 lines, -98 lines 0 comments Download
M base/json/string_escape_unittest.cc View 1 chunk +51 lines, -129 lines 0 comments Download
M base/metrics/statistics_recorder.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/search/iframe_source.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/about_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/policy_ui.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/capabilities.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 chunk +1 line, -1 line 0 comments Download
M jingle/notifier/listener/notification_defines.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M net/base/net_util.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M net/base/net_util_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sync/internal_api/public/base/ordinal.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/public/base/progress_marker_map.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M sync/syncable/entry.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M tools/gn/trace.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/106793004/1
7 years ago (2013-12-11 11:52:01 UTC) #1
Denis Kuznetsov (DE-MUC)
Created Revert of Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.
7 years ago (2013-12-11 11:52:01 UTC) #2
commit-bot: I haz the power
Change committed as 240082
7 years ago (2013-12-11 11:52:25 UTC) #3
Robert Sesek
Screenshot? Bug? Test coverage of this? Which _specific_ strings are broken? This is pretty much ...
7 years ago (2013-12-11 12:29:16 UTC) #4
Denis Kuznetsov (DE-MUC)
7 years ago (2013-12-11 13:59:39 UTC) #5
Message was sent while issue was closed. 
On 2013/12/11 12:29:16, rsesek wrote:
> Screenshot? Bug? Test coverage of this? Which _specific_ strings are broken?
> This is pretty much nothing to go on.

Added all the stuff to original issue.

Powered by Google App Engine
This is Rietveld 408576698