chrome/renderer/searchbox/searchbox_extension.cc - Issue 106793004: Revert of Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 106793004: Revert of Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/searchbox/searchbox_extension.cc

diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc

index 19bc48bacdd7634675a74773dde33922f9c53275..f34b1024b3e8fccbfdda43207a447343aad41ee8 100644

--- a/chrome/renderer/searchbox/searchbox_extension.cc

+++ b/chrome/renderer/searchbox/searchbox_extension.cc

@@ -460,7 +460,8 @@

blink::WebFrame* frame,

const base::string16& identity,

bool identity_match) {

- std::string escaped_identity = base::GetQuotedJSONString(identity);

+ std::string escaped_identity;

+ base::JsonDoubleQuote(identity, true, &escaped_identity);

blink::WebString script(UTF8ToUTF16(base::StringPrintf(

kDispatchChromeIdentityCheckResult,

escaped_identity.c_str(),

« no previous file with comments | « chrome/browser/ui/webui/policy_ui.cc ('k') | chrome/test/chromedriver/capabilities.cc » ('j') | no next file with comments »