sync/syncable/entry.cc - Issue 106793004: Revert of Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/entry.cc

Issue 106793004: Revert of Stop doing unnecessary UTF-8 to UTF-16 conversions in JSONWriter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/syncable/entry.cc

diff --git a/sync/syncable/entry.cc b/sync/syncable/entry.cc

index 852c33e32edee914422dfbf8c4d1d6c5e138df13..3891c55402444383091bf5e4c0946e0c725ee584 100644

--- a/sync/syncable/entry.cc

+++ b/sync/syncable/entry.cc

@@ -147,9 +147,11 @@

os << g_metas_columns[i].name << ": " << field << ", ";

}

for ( ; i < PROTO_FIELDS_END; ++i) {

- std::string escaped_str = base::EscapeBytesAsInvalidJSONString(

+ std::string escaped_str;

+ base::JsonDoubleQuote(

kernel->ref(static_cast<ProtoField>(i)).SerializeAsString(),

- false);

+ false,

+ &escaped_str);

os << g_metas_columns[i].name << ": " << escaped_str << ", ";

}

for ( ; i < UNIQUE_POSITION_FIELDS_END; ++i) {

« no previous file with comments | « sync/internal_api/public/base/progress_marker_map.cc ('k') | tools/gn/trace.cc » ('j') | no next file with comments »