chrome/browser/metrics/plugin_metrics_provider.h - Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/plugin_metrics_provider.h

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_stability_metrics_provider.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/plugin_metrics_provider.h

diff --git a/chrome/browser/metrics/plugin_metrics_provider.h b/chrome/browser/metrics/plugin_metrics_provider.h

index 8d374c98a681ee470ba5801b04bbcaef57935942..a1d8220b6c1efde29009e3e37365291046bf1245 100644

--- a/chrome/browser/metrics/plugin_metrics_provider.h

+++ b/chrome/browser/metrics/plugin_metrics_provider.h

@@ -90,8 +90,8 @@ class PluginMetricsProvider : public metrics::MetricsProvider,

// content::BrowserChildProcessObserver:

void BrowserChildProcessHostConnected(

const content::ChildProcessData& data) override;

- void BrowserChildProcessCrashed(

- const content::ChildProcessData& data) override;

+ void BrowserChildProcessCrashed(const content::ChildProcessData& data,

+ int exit_code) override;

void BrowserChildProcessInstanceCreated(

const content::ChildProcessData& data) override;

« no previous file with comments | « chrome/browser/metrics/chrome_stability_metrics_provider.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »