chrome/browser/metrics/chrome_stability_metrics_provider.cc - Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_stability_metrics_provider.cc

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: code review comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/metrics/chrome_stability_metrics_provider.h ('k') | chrome/browser/metrics/plugin_metrics_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/metrics/chrome_stability_metrics_provider.cc

diff --git a/chrome/browser/metrics/chrome_stability_metrics_provider.cc b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

index a5e31427ff092e2820a66d63b41e5c6df3e83c35..9b6b126b1498990529ee737df8f91a7f42687dee 100644

--- a/chrome/browser/metrics/chrome_stability_metrics_provider.cc

+++ b/chrome/browser/metrics/chrome_stability_metrics_provider.cc

@@ -236,7 +236,8 @@ void ChromeStabilityMetricsProvider::Observe(

}

void ChromeStabilityMetricsProvider::BrowserChildProcessCrashed(

- const content::ChildProcessData& data) {

+ const content::ChildProcessData& data,

+ int exit_code) {

#if defined(ENABLE_PLUGINS)

// Exclude plugin crashes from the count below because we report them via

// a separate UMA metric.

« no previous file with comments | « chrome/browser/metrics/chrome_stability_metrics_provider.h ('k') | chrome/browser/metrics/plugin_metrics_provider.h » ('j') | no next file with comments »