Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(874)

Side by Side Diff: chrome/browser/metrics/plugin_metrics_provider.h

Issue 1067733006: Add extra parameter to BrowserChildProcessCrashed to pass the exit_code at time of crash/termination (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: code review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_
6 #define CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_ 6 #define CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 // The param delay_sec is for unit tests. 83 // The param delay_sec is for unit tests.
84 bool RecordCurrentStateWithDelay(int delay_ms); 84 bool RecordCurrentStateWithDelay(int delay_ms);
85 85
86 // If a delayed RecordCurrnetState task exists then cancels it, calls 86 // If a delayed RecordCurrnetState task exists then cancels it, calls
87 // RecordCurrentState immediately and returns true. Otherwise returns false. 87 // RecordCurrentState immediately and returns true. Otherwise returns false.
88 bool RecordCurrentStateIfPending(); 88 bool RecordCurrentStateIfPending();
89 89
90 // content::BrowserChildProcessObserver: 90 // content::BrowserChildProcessObserver:
91 void BrowserChildProcessHostConnected( 91 void BrowserChildProcessHostConnected(
92 const content::ChildProcessData& data) override; 92 const content::ChildProcessData& data) override;
93 void BrowserChildProcessCrashed( 93 void BrowserChildProcessCrashed(const content::ChildProcessData& data,
94 const content::ChildProcessData& data) override; 94 int exit_code) override;
95 void BrowserChildProcessInstanceCreated( 95 void BrowserChildProcessInstanceCreated(
96 const content::ChildProcessData& data) override; 96 const content::ChildProcessData& data) override;
97 97
98 PrefService* local_state_; 98 PrefService* local_state_;
99 99
100 // The list of plugins which was retrieved on the file thread. 100 // The list of plugins which was retrieved on the file thread.
101 std::vector<content::WebPluginInfo> plugins_; 101 std::vector<content::WebPluginInfo> plugins_;
102 102
103 // Buffer of child process notifications for quick access. 103 // Buffer of child process notifications for quick access.
104 std::map<base::string16, ChildProcessStats> child_process_stats_buffer_; 104 std::map<base::string16, ChildProcessStats> child_process_stats_buffer_;
105 105
106 base::WeakPtrFactory<PluginMetricsProvider> weak_ptr_factory_; 106 base::WeakPtrFactory<PluginMetricsProvider> weak_ptr_factory_;
107 107
108 DISALLOW_COPY_AND_ASSIGN(PluginMetricsProvider); 108 DISALLOW_COPY_AND_ASSIGN(PluginMetricsProvider);
109 }; 109 };
110 110
111 #endif // CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_ 111 #endif // CHROME_BROWSER_METRICS_PLUGIN_METRICS_PROVIDER_H_
OLDNEW
« no previous file with comments | « chrome/browser/metrics/chrome_stability_metrics_provider.cc ('k') | chrome/browser/metrics/plugin_metrics_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698