Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1067733003: Handle GPU command buffer client side Get* caching. (Closed)

Created:
5 years, 8 months ago by Zhenyao Mo
Modified:
5 years, 8 months ago
Reviewers:
zmo, piman
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, Ken Russell (switch to Gerrit), bajones, no sievers, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle GPU command buffer client side Get* caching. BUG=429053 TEST=gpu_unittests R=piman@chromium.org Committed: https://crrev.com/ba1fe9d271fb20cbfe7353b140ff63d47c549732 Cr-Commit-Position: refs/heads/master@{#325314}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -27 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 3 chunks +241 lines, -22 lines 0 comments Download
M gpu/command_buffer/common/capabilities.h View 1 2 chunks +30 lines, -0 lines 0 comments Download
M gpu/command_buffer/common/capabilities.cc View 1 2 chunks +29 lines, -1 line 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils_implementation_autogen.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
zmo
piman: please take a look. Others: FYI (feel free to review also).
5 years, 8 months ago (2015-04-15 00:36:45 UTC) #3
zmo
bajones: I vaguely remember you encountered an ENUM which is only available in very late ...
5 years, 8 months ago (2015-04-15 00:43:00 UTC) #4
piman
lgtm
5 years, 8 months ago (2015-04-15 04:39:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067733003/40001
5 years, 8 months ago (2015-04-15 20:56:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 8 months ago (2015-04-15 21:43:04 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 21:43:54 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ba1fe9d271fb20cbfe7353b140ff63d47c549732
Cr-Commit-Position: refs/heads/master@{#325314}

Powered by Google App Engine
This is Rietveld 408576698