Factor out reporting from rules

Factor out reporting from rules

This changes the RestrictedTypeRules to eliminate a direct dependency on CheckerReporter.  Instead of logging a missing type error with the reporter directly, it now calls an optional callback.  The Checker registers an appropriate callback for its errors.  Currently the code generators don't log these errors.  This eliminates the dependency of the code generators on the checker reporter.

BUG=
R=jmesserly@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/375f3da2bc662bd74c9ba696b3bbe9c79eab2f6c

[Leaf, 2015-04-07 00:41:36]

leafp@google.com changed reviewers:
+ jmesserly@google.com

[Jennifer Messerly, 2015-04-07 14:52:23]

LGTM. A+ would LGTM again :)

https://codereview.chromium.org/1067553004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (right):

https://codereview.chromium.org/1067553004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:95: set reportMissingType(MissingTypeReporter
callback) => _reporter = callback;
this should just be a field?

MissingTypeReporter reportMissingType;

it will induce the getter/setter pair

[Leaf, 2015-04-07 16:56:25]

https://codereview.chromium.org/1067553004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (right):

https://codereview.chromium.org/1067553004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:95: set reportMissingType(MissingTypeReporter
callback) => _reporter = callback;
On 2015/04/07 14:52:22, John Messerly wrote:
> this should just be a field?
> 
> MissingTypeReporter reportMissingType;
> 
> it will induce the getter/setter pair

Done.

[Leaf, 2015-04-07 16:58:18]

Committed patchset #2 (id:20001) manually as
375f3da2bc662bd74c9ba696b3bbe9c79eab2f6c (presubmit successful).