Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Unified Diff: lib/src/codegen/code_generator.dart

Issue 1067553004: Factor out reporting from rules (Closed) Base URL: git@github.com:dart-lang/dart-dev-compiler.git@master
Patch Set: Change set/get pair to field Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/checker/rules.dart ('k') | lib/src/codegen/dart_codegen.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/code_generator.dart
diff --git a/lib/src/codegen/code_generator.dart b/lib/src/codegen/code_generator.dart
index dcc63026ca84d7baac1cd1a455aa9cbd27638e6b..ee16c93d75a1a2a3036cc6fdf8a0d71699d6ad54 100644
--- a/lib/src/codegen/code_generator.dart
+++ b/lib/src/codegen/code_generator.dart
@@ -13,7 +13,6 @@ import 'package:path/path.dart' as path;
import 'package:dev_compiler/src/info.dart';
import 'package:dev_compiler/src/utils.dart' show canonicalLibraryName;
-import 'package:dev_compiler/src/report.dart';
import 'package:dev_compiler/src/checker/rules.dart';
abstract class CodeGenerator {
@@ -132,6 +131,5 @@ abstract class CodeGenerator {
/// Return a hash, if any, that can be used for caching purposes. When two
/// invocations to this function return the same hash, the underlying
/// code-generator generated the same code.
- String generateLibrary(
- LibraryUnit unit, LibraryInfo info, CheckerReporter reporter);
+ String generateLibrary(LibraryUnit unit, LibraryInfo info);
}
« no previous file with comments | « lib/src/checker/rules.dart ('k') | lib/src/codegen/dart_codegen.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698