Factor out reporting from rules

lib/devc.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Command line tool to run the checker on a Dart program.
 library dev_compiler.devc;
 
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io';
@@ skipping 50 matching lines @@
           ? new TypeResolver.fromMock(mockSdkSources, options)
           : new TypeResolver.fromDir(options.dartSdkPath, options);
     }
 
     if (reporter == null) {
       reporter = options.dumpInfo
           ? new SummaryReporter()
           : new LogReporter(options.useColors);
     }
     var graph = new SourceGraph(resolver.context, reporter, options);
-    var rules = new RestrictedRules(resolver.context.typeProvider, reporter,
-        options: options);
+    var rules =
+        new RestrictedRules(resolver.context.typeProvider, options: options);
     var checker = new CodeChecker(rules, reporter, options);
     var inputFile = options.entryPointFile;
     var uri = inputFile.startsWith('dart:') || inputFile.startsWith('package:')
         ? Uri.parse(inputFile)
         : new Uri.file(path.absolute(inputFile));
     var entryNode = graph.nodeFromUri(uri);
 
     var outputDir = options.outputDir;
     var generators = <CodeGenerator>[];
     if (options.dumpSrcDir != null) {
@@ skipping 87 matching lines @@
     var resolvedParts = node.parts
         .map((p) => _resolver.context.resolveCompilationUnit2(p.source, source))
         .toList(growable: false);
     var libraryUnit = new LibraryUnit(entryUnit, resolvedParts);
     bool failureInLib = false;
     for (var unit in libraryUnit.libraryThenParts) {
       var unitSource = unit.element.source;
       _reporter.enterSource(unitSource);
       // TODO(sigmund): integrate analyzer errors with static-info (issue #6).
       failureInLib = _resolver.logErrors(unitSource, _reporter) || failureInLib;
-      unit.visitChildren(_checker);
+      _checker.visitCompilationUnit(unit);
       if (_checker.failure) failureInLib = true;
       _reporter.leaveSource();
     }
     if (failureInLib) {
       _failure = true;
       if (!_options.forceCompile) return;
     }
 
     for (var cg in _generators) {
-      var hash = cg.generateLibrary(libraryUnit, current, _reporter);
+      var hash = cg.generateLibrary(libraryUnit, current);
       if (_hashing) node.cachingHash = hash;
     }
     _reporter.leaveLibrary();
   }
 
   CheckerResults run() {
     var clock = new Stopwatch()..start();
 
     // TODO(sigmund): we are missing a couple failures here. The
     // dependency_graph now detects broken imports or unsupported features
@@ skipping 105 matching lines @@
       // Note: the cache-control header should be enough, but this doesn't hurt
       // and can help renew the policy after it expires.
       headers['ETag'] = segments[1];
     }
     return response.change(headers: headers);
   };
 }
 
 final _log = new Logger('dev_compiler');
 final _earlyErrorResult = new CheckerResults(const [], null, true);