Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1067423002: Improve DCHECK in PropertyTree::UpdateSnapping (Closed)

Created:
5 years, 8 months ago by Ian Vollick
Modified:
5 years, 8 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Improve DCHECK in PropertyTree::UpdateSnapping We DCHECK that the snap matrix is indentity or a 2D translation, but the computation of this matrix is prone to floating point error, so an approximate check makes more sense here. BUG=None Committed: https://crrev.com/e44d0bb8e278e241157df15962d138f03521d512 Cr-Commit-Position: refs/heads/master@{#324247}

Patch Set 1 #

Patch Set 2 : SkDoubleToMScalar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M cc/trees/property_tree.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
ajuma
lgtm
5 years, 8 months ago (2015-04-08 14:38:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067423002/1
5 years, 8 months ago (2015-04-08 14:40:36 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/27155)
5 years, 8 months ago (2015-04-08 15:44:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067423002/20001
5 years, 8 months ago (2015-04-08 15:52:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-08 17:26:08 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 17:26:55 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e44d0bb8e278e241157df15962d138f03521d512
Cr-Commit-Position: refs/heads/master@{#324247}

Powered by Google App Engine
This is Rietveld 408576698