cc/trees/property_tree.cc - Issue 1067423002: Improve DCHECK in PropertyTree::UpdateSnapping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/property_tree.cc

Issue 1067423002: Improve DCHECK in PropertyTree::UpdateSnapping (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: SkDoubleToMScalar Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/property_tree.cc

diff --git a/cc/trees/property_tree.cc b/cc/trees/property_tree.cc

index ea0b2ed4d8d864e550a4eaa827ac0094177226f8..b1fd5e4e7ce0ca5eaa0044fca364f527a59b6b91 100644

--- a/cc/trees/property_tree.cc

+++ b/cc/trees/property_tree.cc

@@ -312,7 +312,8 @@ void TransformTree::UpdateSnapping(TransformNode* node) {

gfx::Transform delta = node->data.from_target;

delta *= rounded;

- DCHECK(delta.IsIdentityOr2DTranslation());

+ DCHECK(delta.IsApproximatelyIdentityOrTranslation(SkDoubleToMScalar(1e-4)))

+ << delta.ToString();

gfx::Vector2dF translation = delta.To2dTranslation();

« no previous file with comments | « no previous file | no next file » | no next file with comments »