Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1067203002: bindings: Use Maybe APIs in V8DevToolsHostCustom (Closed)

Created:
5 years, 8 months ago by bashi
Modified:
5 years, 8 months ago
Reviewers:
haraken, yurys, Yuki
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, malch+blink_chromium.org, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, loislo+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

bindings: Use Maybe APIs in V8DevToolsHostCustom BUG=462402 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193354

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -8 lines) Patch
M Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 1 2 chunks +19 lines, -8 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bashi
PTAL?
5 years, 8 months ago (2015-04-08 03:01:41 UTC) #2
haraken
LGTM
5 years, 8 months ago (2015-04-08 03:29:44 UTC) #3
Yuki
lgtm https://codereview.chromium.org/1067203002/diff/1/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp File Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp (right): https://codereview.chromium.org/1067203002/diff/1/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp#newcode63 Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp:63: v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(itemArray->Get(context, i).ToLocalChecked()); Why don't you ...
5 years, 8 months ago (2015-04-08 04:55:59 UTC) #4
bashi
https://codereview.chromium.org/1067203002/diff/1/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp File Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp (right): https://codereview.chromium.org/1067203002/diff/1/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp#newcode63 Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp:63: v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(itemArray->Get(context, i).ToLocalChecked()); On 2015/04/08 04:55:59, Yuki ...
5 years, 8 months ago (2015-04-08 07:40:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1067203002/20001
5 years, 8 months ago (2015-04-08 07:40:34 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 12:44:14 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193354

Powered by Google App Engine
This is Rietveld 408576698