bindings: Use Maybe APIs in V8DevToolsHostCustom

Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp

 /*
  * Copyright (C) 2007-2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 40 matching lines @@
     v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "mac"));
 #elif OS(WIN)
     v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "windows"));
 #else // Unix-like systems
     v8SetReturnValue(info, v8AtomicString(info.GetIsolate(), "linux"));
 #endif
 }
 
 static bool populateContextMenuItems(const v8::Local<v8::Array>& itemArray, ContextMenu& menu, v8::Isolate* isolate)
 {
+    v8::Local<v8::Context> context = isolate->GetCurrentContext();
     for (size_t i = 0; i < itemArray->Length(); ++i) {
-        v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(itemArray->Get(i));
-        v8::Local<v8::Value> type = item->Get(v8AtomicString(isolate, "type"));
-        v8::Local<v8::Value> id = item->Get(v8AtomicString(isolate, "id"));
-        v8::Local<v8::Value> label = item->Get(v8AtomicString(isolate, "label"));
-        v8::Local<v8::Value> enabled = item->Get(v8AtomicString(isolate, "enabled"));
-        v8::Local<v8::Value> checked = item->Get(v8AtomicString(isolate, "checked"));
-        v8::Local<v8::Value> subItems = item->Get(v8AtomicString(isolate, "subItems"));
+        v8::Local<v8::Object> item = v8::Local<v8::Object>::Cast(itemArray->Get(context, i).ToLocalChecked());

[Yuki, 2015/04/08 04:55:59]

Why don't you use As()?  Why Cast()?

[bashi, 2015/04/08 07:40:01]

Since I just added |context| and ToLocalChecked() :) Anyway, changed to use
As().

+        v8::Local<v8::Value> type;
+        v8::Local<v8::Value> id;
+        v8::Local<v8::Value> label;
+        v8::Local<v8::Value> enabled;
+        v8::Local<v8::Value> checked;
+        v8::Local<v8::Value> subItems;
+        if (!item->Get(context, v8AtomicString(isolate, "type")).ToLocal(&type)
+            || !item->Get(context, v8AtomicString(isolate, "id")).ToLocal(&id)
+            || !item->Get(context, v8AtomicString(isolate, "label")).ToLocal(&label)
+            || !item->Get(context, v8AtomicString(isolate, "enabled")).ToLocal(&enabled)
+            || !item->Get(context, v8AtomicString(isolate, "checked")).ToLocal(&checked)
+            || !item->Get(context, v8AtomicString(isolate, "subItems")).ToLocal(&subItems))
+            return false;
         if (!type->IsString())
             continue;
         String typeString = toCoreStringWithNullCheck(type.As<v8::String>());
         if (typeString == "separator") {
             ContextMenuItem item(ContextMenuItem(SeparatorType,
                 ContextMenuItemCustomTagNoAction,
                 String(),
                 String()));
             menu.appendItem(item);
         } else if (typeString == "subMenu" && subItems->IsArray()) {
             ContextMenu subMenu;
             v8::Local<v8::Array> subItemsArray = v8::Local<v8::Array>::Cast(subItems);
             if (!populateContextMenuItems(subItemsArray, subMenu, isolate))
                 return false;
             TOSTRING_DEFAULT(V8StringResource<TreatNullAsNullString>, labelString, label, false);
             ContextMenuItem item(SubmenuType,
                 ContextMenuItemCustomTagNoAction,
                 labelString,
                 String(),
                 &subMenu);
             menu.appendItem(item);
         } else {
-            ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + id->ToInt32(isolate)->Value());
+            int32_t int32Id;
+            if (!v8Call(id->Int32Value(context), int32Id))
+                return false;
+            ContextMenuAction typedId = static_cast<ContextMenuAction>(ContextMenuItemBaseCustomTag + int32Id);
             TOSTRING_DEFAULT(V8StringResource<TreatNullAsNullString>, labelString, label, false);
             ContextMenuItem menuItem((typeString == "checkbox" ? CheckableActionType : ActionType), typedId, labelString, String());
             if (checked->IsBoolean())
                 menuItem.setChecked(checked.As<v8::Boolean>()->Value());
             if (enabled->IsBoolean())
                 menuItem.setEnabled(enabled.As<v8::Boolean>()->Value());
             menu.appendItem(menuItem);
         }
     }
     return true;
@@ skipping 56 matching lines @@
     if (!document || !document->frame())
         return;
 
     DevToolsHost* devtoolsHost = V8DevToolsHost::toImpl(info.Holder());
     Vector<ContextMenuItem> items = menu.items();
     devtoolsHost->showContextMenu(document->frame(), x, y, items);
 }
 
 } // namespace blink