Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 1066613003: Revert of Calculate inverse scale for distance fields in vertex shader (Closed)

Created:
5 years, 8 months ago by jvanverth1
Modified:
5 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Calculate inverse scale for distance fields in vertex shader (patchset #6 id:100001 of https://codereview.chromium.org/1029423003/) Reason for revert: This appears to be breaking large text on Nexus 7. Original issue's description: > Calculate inverse scale for distance field text in vertex shader > > This is for the uniform scale case only. Using the dFdx() function on certain > Mali GPUs causes issues because the precision is too low, so we have to > compute 1/scale from the view matrix instead. > > BUG=skia:3528 > > Committed: https://skia.googlesource.com/skia/+/5b143038cb47763974d2750ed78d436eb6c38bea TBR=bsalomon@google.com,joshualitt@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3528 Committed: https://skia.googlesource.com/skia/+/ff271c29a64f59d538e644210b0f207666f856b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -141 lines) Patch
M src/gpu/GrDistanceFieldTextContext.cpp View 7 chunks +7 lines, -32 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.h View 4 chunks +15 lines, -19 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 11 chunks +41 lines, -90 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jvanverth1
Created Revert of Calculate inverse scale for distance fields in vertex shader
5 years, 8 months ago (2015-04-06 20:58:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1066613003/1
5 years, 8 months ago (2015-04-06 20:58:54 UTC) #2
commit-bot: I haz the power
5 years, 8 months ago (2015-04-06 20:59:02 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ff271c29a64f59d538e644210b0f207666f856b5

Powered by Google App Engine
This is Rietveld 408576698